<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> <p style="margin-top:0;margin-bottom:0">Reviewed-by: Alex Deucher <alexander.deucher@amd.com><br> </p> </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Yang, Philip <Philip.Yang@amd.com><br> <b>Sent:</b> Monday, November 19, 2018 3:20:00 PM<br> <b>To:</b> amd-gfx@lists.freedesktop.org<br> <b>Cc:</b> Yang, Philip<br> <b>Subject:</b> [PATCH 1/3] drm/amdgpu: fix typo in function sdma_v4_0_page_resume</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">This looks like copy paste typo<br> <br> Change-Id: Iee3fd3a551650ec9199bc030a7886e92000b02e7<br> Signed-off-by: Philip Yang <Philip.Yang@amd.com><br> ---<br> drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 6 ++----<br> 1 file changed, 2 insertions(+), 4 deletions(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c<br> index f4490cdd9804..3f6b7882dbd2 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c<br> @@ -925,11 +925,9 @@ static void sdma_v4_0_page_resume(struct amdgpu_device *adev, unsigned int i)<br> OFFSET, ring->doorbell_index);<br> WREG32_SDMA(i, mmSDMA0_PAGE_DOORBELL, doorbell);<br> WREG32_SDMA(i, mmSDMA0_PAGE_DOORBELL_OFFSET, doorbell_offset);<br> - /* TODO: enable doorbell support */<br> - /*adev->nbio_funcs->sdma_doorbell_range(adev, i, ring->use_doorbell,<br> - ring->doorbell_index);*/<br> <br> - sdma_v4_0_ring_set_wptr(ring);<br> + /* paging queue doorbell range is setup at sdma_v4_0_gfx_resume */<br> + sdma_v4_0_page_ring_set_wptr(ring);<br> <br> /* set minor_ptr_update to 0 after wptr programed */<br> WREG32_SDMA(i, mmSDMA0_PAGE_MINOR_PTR_UPDATE, 0);<br> -- <br> 2.17.1<br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br> </div> </span></font></div> </body> </html>