<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">Do we still need the HSA_AMD option ? <br>
</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">Seems to me that KFD stopped being "something we only sometimes include" a long time ago.
<br>
</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">Thanks,<br>
John<br>
</p>
<br>
<div style="color: rgb(0, 0, 0);">
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of StDenis, Tom <Tom.StDenis@amd.com><br>
<b>Sent:</b> December 10, 2018 10:02 AM<br>
<b>To:</b> Kuehling, Felix<br>
<b>Cc:</b> Huang, JinHuiEric; Deucher, Alexander; amd-gfx mailing list<br>
<b>Subject:</b> amdkfd build regression if HSA_AMD is disabled</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Hi All,<br>
<br>
The commit:<br>
<br>
commit 62f65d3cb34a8300bf1e07fc478e03c3c02634d4<br>
Refs: v4.20-rc3-524-g62f65d3cb34a<br>
Author: Felix Kuehling <Felix.Kuehling@amd.com><br>
AuthorDate: Mon Nov 19 20:05:54 2018 -0500<br>
Commit: Felix Kuehling <Felix.Kuehling@amd.com><br>
CommitDate: Fri Dec 7 17:17:11 2018 -0500<br>
<br>
drm/amdgpu: Add KFD VRAM limit checking<br>
<br>
We don't want KFD processes evicting each other over VRAM usage.<br>
Therefore prevent overcommitting VRAM among KFD applications with<br>
a per-GPU limit. Also leave enough room for page tables on top<br>
of the application memory usage.<br>
<br>
Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com><br>
Reviewed-by: Eric Huang <JinHuiEric.Huang@amd.com><br>
Acked-by: Alex Deucher <alexander.deucher@amd.com><br>
<br>
Breaks the build if HSA_AMD is not enabled:<br>
<br>
scripts/kconfig/conf --syncconfig Kconfig<br>
DESCEND objtool<br>
CALL scripts/checksyscalls.sh<br>
CHK include/generated/compile.h<br>
Building modules, stage 2.<br>
MODPOST 63 modules<br>
Kernel: arch/x86/boot/bzImage is ready (#58)<br>
ERROR: "amdgpu_amdkfd_unreserve_memory_limit" <br>
[drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!<br>
make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1<br>
make: *** [Makefile:1271: modules] Error 2<br>
<br>
This is because the function being used is not included in the build <br>
(the previous function called was part of amdgpu_amdkfd.c which is <br>
unconditionally built).<br>
<br>
Cheers,<br>
Tom<br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br>
</div>
</span></font></div>
</div>
</div>
</body>
</html>