<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=Windows-1252"> </head> <body text="#000000" bgcolor="#FFFFFF"> <div class="moz-cite-prefix">Never mind, just saw the patch to fix the typo. On 2018-12-10 1:07 p.m., Yang, Philip wrote: </div> <blockquote type="cite" cite="mid:18e5b0c7-1d33-a385-38c1-6a14663b9b60@amd.com"> <div class="moz-cite-prefix">I got this compilation error message after I rebase this morning, do I miss anything? /home/yangp/git/compute_staging/kernel/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c: In function ‘gfx_v8_0_rlc_resume’: /home/yangp/git/compute_staging/kernel/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:4071:6: error: implicit declaration of function ‘amdgpu_sriov’; did you mean ‘amdgpu_sriov_vf’? [-Werror=implicit-function-declaration] if (amdgpu_sriov(adev)) { ^~~~~~~~~~~~ amdgpu_sriov_vf cc1: some warnings being treated as errors /home/yangp/git/compute_staging/kernel/scripts/Makefile.build:293: recipe for target 'drivers/gpu/drm/amd/amdgpu/gfx_v8_0.o' failed make[10]: *** [drivers/gpu/drm/amd/amdgpu/gfx_v8_0.o] Error 1 Philip On 2018-12-07 10:33 a.m., Deucher, Alexander wrote: </div> <blockquote type="cite" cite="mid:BN6PR12MB180903FE05AC850D8D4BFEC9F7AA0@BN6PR12MB1809.namprd12.prod.outlook.com"> <style type="text/css" style="display:none;"></style> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> Acked-by: Alex Deucher <a class="moz-txt-link-rfc2396E" href="mailto:alexander.deucher@amd.com" moz-do-not-send="true"> <alexander.deucher@amd.com></a> </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr">From: amd-gfx <a class="moz-txt-link-rfc2396E" href="mailto:amd-gfx-bounces@lists.freedesktop.org" moz-do-not-send="true"> <amd-gfx-bounces@lists.freedesktop.org></a> on behalf of Tiecheng Zhou <a class="moz-txt-link-rfc2396E" href="mailto:Tiecheng.Zhou@amd.com" moz-do-not-send="true"> <Tiecheng.Zhou@amd.com></a> Sent: Thursday, December 6, 2018 9:11:49 PM To: <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org" moz-do-not-send="true"> amd-gfx@lists.freedesktop.org</a> Cc: Zhou, Tiecheng Subject: [PATCH] drm/amdgpu: bypass RLC init under sriov for Tonga <div> </div> </div> <div class="BodyFragment"> <div class="PlainText">SWDEV-173384: vm-mix reboot (4 VMs) fail on Tonga under sriov Phenomena: there is compute_1.3.1 ring test fail on one VM when it starts to do hw_init after it is rebooted Root cause: RLC will go wrong in soft_reset under sriov Workaround: init RLC csb, and skip RLC stop, reset, start this is because GIM has already done full initialization on RLC refer to 'commit cfee05bc9057 ("drm/amdgpu:bypass RLC init for SRIOV")' and 'commit f840cc5f8447 ("drm/amdgpu/sriov:init csb for gfxv9")' Signed-off-by: Tiecehng Zhou <a class="moz-txt-link-rfc2396E" href="mailto:Tiecheng.Zhou@amd.com" moz-do-not-send="true"> <Tiecheng.Zhou@amd.com></a> --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c index 1454fc3..a9c853a 100644 --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c @@ -4068,6 +4068,11 @@ static void gfx_v8_0_rlc_start(struct amdgpu_device *adev) static int gfx_v8_0_rlc_resume(struct amdgpu_device *adev) { + if (amdgpu_sriov(adev)) { + gfx_v8_0_init_csb(adev); + return 0; + } + adev->gfx.rlc.funcs->stop(adev); adev->gfx.rlc.funcs->reset(adev); gfx_v8_0_init_pg(adev); -- 2.7.4 _______________________________________________ amd-gfx mailing list <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org" moz-do-not-send="true">amd-gfx@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" moz-do-not-send="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> </div> </div> <fieldset class="mimeAttachmentHeader"></fieldset> <pre class="moz-quote-pre" wrap="">_______________________________________________ amd-gfx mailing list <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org" moz-do-not-send="true">amd-gfx@lists.freedesktop.org</a> <a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" moz-do-not-send="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> </pre> </blockquote> <fieldset class="mimeAttachmentHeader"></fieldset> <pre class="moz-quote-pre" wrap="">_______________________________________________ amd-gfx mailing list <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> </pre> </blockquote> </body> </html>