<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">vbios asic init will still work. It will wait on the psp init so I'd suggest we just drop this patch to keep the code consistent. There are also possibly some registers that are handled by vbios asic init rather than
psp.</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">Alex<br>
</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Feifei Xu <Feifei.Xu@amd.com><br>
<b>Sent:</b> Sunday, December 9, 2018 11:45:52 PM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org<br>
<b>Cc:</b> Xu, Feifei<br>
<b>Subject:</b> [PATCH] drm/amdgpu:skip ASIC_INIT when posting card on vg20</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">On vega20, the job of executing the ASIC_INIT table when posting card<br>
is moved to psp. Skip the atombios's ASIC_INIT on vega20 when posting<br>
card.<br>
<br>
Change-Id: Id1d3c0a0d19296d5ed804de7edf5b09b8d38c0a5<br>
Signed-off-by: Feifei Xu <Feifei.Xu@amd.com><br>
---<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ++-<br>
1 file changed, 2 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br>
index f2bda76c8e05..310d4eb0536b 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br>
@@ -2513,8 +2513,9 @@ int amdgpu_device_init(struct amdgpu_device *adev,<br>
/* detect if we are with an SRIOV vbios */<br>
amdgpu_device_detect_sriov_bios(adev);<br>
<br>
+ DRM_INFO("skip posting card using ASIC INIT table in vbios on vega20\n");<br>
/* Post card if necessary */<br>
- if (amdgpu_device_need_post(adev)) {<br>
+ if ((adev->asic_type != CHIP_VEGA20) && amdgpu_device_need_post(adev)) {<br>
if (!adev->bios) {<br>
dev_err(adev->dev, "no vBIOS found\n");<br>
r = -EINVAL;<br>
-- <br>
2.17.1<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br>
</div>
</span></font></div>
</body>
</html>