<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">Reviewed-by: Alex Deucher <alexander.deucher@amd.com></p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Liu, Leo <Leo.Liu@amd.com><br>
<b>Sent:</b> Tuesday, December 11, 2018 4:03 PM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org<br>
<b>Cc:</b> Liu, Leo<br>
<b>Subject:</b> [PATCH libdrm] tests/amdgpu/vcn: fix the nop command in IBs</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText">Just make them properly i.e. put 0 to the Nop reg<br>
<br>
Signed-off-by: Leo Liu <leo.liu@amd.com><br>
---<br>
tests/amdgpu/vcn_tests.c | 18 ++++++++++++------<br>
1 file changed, 12 insertions(+), 6 deletions(-)<br>
<br>
diff --git a/tests/amdgpu/vcn_tests.c b/tests/amdgpu/vcn_tests.c<br>
index d9f05af8..859ec496 100644<br>
--- a/tests/amdgpu/vcn_tests.c<br>
+++ b/tests/amdgpu/vcn_tests.c<br>
@@ -268,8 +268,10 @@ static void amdgpu_cs_vcn_dec_create(void)<br>
ib_cpu[len++] = msg_buf.addr >> 32;<br>
ib_cpu[len++] = 0x81C3;<br>
ib_cpu[len++] = 0;<br>
- for (; len % 16; ++len)<br>
- ib_cpu[len] = 0x81ff;<br>
+ for (; len % 16; ) {<br>
+ ib_cpu[len++] = 0x81ff;<br>
+ ib_cpu[len++] = 0;<br>
+ }<br>
<br>
r = submit(len, AMDGPU_HW_IP_VCN_DEC);<br>
CU_ASSERT_EQUAL(r, 0);<br>
@@ -336,8 +338,10 @@ static void amdgpu_cs_vcn_dec_decode(void)<br>
<br>
ib_cpu[len++] = 0x81C6;<br>
ib_cpu[len++] = 0x1;<br>
- for (; len % 16; ++len)<br>
- ib_cpu[len] = 0x80000000;<br>
+ for (; len % 16; ) {<br>
+ ib_cpu[len++] = 0x81ff;<br>
+ ib_cpu[len++] = 0;<br>
+ }<br>
<br>
r = submit(len, AMDGPU_HW_IP_VCN_DEC);<br>
CU_ASSERT_EQUAL(r, 0);<br>
@@ -373,8 +377,10 @@ static void amdgpu_cs_vcn_dec_destroy(void)<br>
ib_cpu[len++] = msg_buf.addr >> 32;<br>
ib_cpu[len++] = 0x81C3;<br>
ib_cpu[len++] = 0;<br>
- for (; len % 16; ++len)<br>
- ib_cpu[len] = 0x80000000;<br>
+ for (; len % 16; ) {<br>
+ ib_cpu[len++] = 0x81ff;<br>
+ ib_cpu[len++] = 0;<br>
+ }<br>
<br>
r = submit(len, AMDGPU_HW_IP_VCN_DEC);<br>
CU_ASSERT_EQUAL(r, 0);<br>
-- <br>
2.17.1<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk53758" class="OWAAutoLink" previewremoved="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a>
<div id="LPBorder_GT_15445623887420.5236685554508548" style="margin-bottom: 20px; overflow: auto; width: 100%; text-indent: 0px;">
<table id="LPContainer_15445623887380.1564058365798745" style="width: 90%; background-color: rgb(255, 255, 255); position: relative; overflow: auto; padding-top: 20px; padding-bottom: 20px; margin-top: 20px; border-top: 1px dotted rgb(200, 200, 200); border-bottom: 1px dotted rgb(200, 200, 200);" role="presentation" cellspacing="0">
<tbody>
<tr style="border-spacing: 0px;" valign="top">
<td id="TextCell_15445623887390.032671432095180974" style="vertical-align: top; position: relative; padding: 0px; display: table-cell;" colspan="2">
<div id="LPRemovePreviewContainer_15445623887390.6231212730891129"></div>
<div id="LPTitle_15445623887390.5213951363639248" style="top: 0px; color: rgb(0, 120, 215); font-weight: 400; font-size: 21px; font-family: "wf_segoe-ui_light", "Segoe UI Light", "Segoe WP Light", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; line-height: 21px;">
<a id="LPUrlAnchor_15445623887400.8061479971000387" style="text-decoration: none;" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank">amd-gfx Info Page - freedesktop.org</a></div>
<div id="LPMetadata_15445623887400.8280153656906918" style="margin: 10px 0px 16px; color: rgb(102, 102, 102); font-weight: 400; font-family: "wf_segoe-ui_normal", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 14px;">
lists.freedesktop.org</div>
<div id="LPDescription_15445623887410.3923663823028356" style="display: block; color: rgb(102, 102, 102); font-weight: 400; font-family: "wf_segoe-ui_normal", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 20px; max-height: 100px; overflow: hidden;">
To see the collection of prior postings to the list, visit the amd-gfx Archives.. Using amd-gfx: To post a message to all the list members, send email to amd-gfx@lists.freedesktop.org. You can subscribe to the list, or change your existing subscription, in
the sections below.</div>
</td>
</tr>
</tbody>
</table>
</div>
<br>
</div>
</span></font></div>
</div>
</body>
</html>