<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> <p style="margin-top:0;margin-bottom:0">Reviewed-by: Alex Deucher <alexander.deuche@amd.com><br> </p> </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Michel Dänzer <michel@daenzer.net><br> <b>Sent:</b> Thursday, December 13, 2018 11:06:35 AM<br> <b>To:</b> amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> [PATCH] drm/amdgpu: WARN once if amdgpu_bo_unpin is called for an unpinned BO</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">From: Michel Dänzer <michel.daenzer@amd.com><br> <br> It indicates a pin/unpin imbalance bug somewhere. While the bug isn't<br> necessarily in the call chain hitting this, it's at least one part<br> involved.<br> <br> Signed-off-by: Michel Dänzer <michel.daenzer@amd.com><br> ---<br> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c<br> index fd271f9746a2..728e15e5d68a 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c<br> @@ -912,7 +912,7 @@ int amdgpu_bo_unpin(struct amdgpu_bo *bo)<br> struct ttm_operation_ctx ctx = { false, false };<br> int r, i;<br> <br> - if (!bo->pin_count) {<br> + if (WARN_ON_ONCE(!bo->pin_count)) {<br> dev_warn(adev->dev, "%p unpin not necessary\n", bo);<br> return 0;<br> }<br> -- <br> 2.20.0.rc2<br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br> </div> </span></font></div> </body> </html>