<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">Reviewed-by: Alex Deucher <alexander.deucher@amd.com><br>
</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Liu, Shaoyun <Shaoyun.Liu@amd.com><br>
<b>Sent:</b> Monday, January 7, 2019 11:01:51 AM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org<br>
<b>Subject:</b> RE: [PATCH] drm/amdgpu: Add message print when unable to get valid hive</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Ping ...<br>
<br>
-----Original Message-----<br>
From: Liu, Shaoyun <Shaoyun.Liu@amd.com> <br>
Sent: Friday, January 4, 2019 1:29 PM<br>
To: amd-gfx@lists.freedesktop.org<br>
Cc: Liu, Shaoyun <Shaoyun.Liu@amd.com><br>
Subject: [PATCH] drm/amdgpu: Add message print when unable to get valid hive<br>
<br>
Add message print out and return -EINVAL when driver can not get valid hive from hive arrary on xgmi configuration<br>
<br>
Change-Id: Ic03927904edf0e384b8c4651e19274bb3f2a7d9a<br>
Signed-off-by: shaoyunl <shaoyun.liu@amd.com><br>
---<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c | 7 ++++++-<br>
1 file changed, 6 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c<br>
index 8a8bc60..b226631 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_xgmi.c<br>
@@ -113,8 +113,13 @@ int amdgpu_xgmi_add_device(struct amdgpu_device *adev)<br>
<br>
mutex_lock(&xgmi_mutex);<br>
hive = amdgpu_get_xgmi_hive(adev);<br>
- if (!hive)<br>
+ if (!hive) {<br>
+ ret = -EINVAL;<br>
+ dev_err(adev->dev,<br>
+ "XGMI: Can not matech hive 0xllx in the hive list.\n",<br>
+ adev->gmc.xgmi.hive_id);<br>
goto exit;<br>
+ }<br>
<br>
hive_topology = &hive->topology_info;<br>
<br>
--<br>
2.7.4<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br>
</div>
</span></font></div>
</body>
</html>