<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple"> <div class="WordSection1"> Hi, Alex,<o:p></o:p> <o:p> </o:p> You are right!<o:p></o:p> <o:p> </o:p> Thanks,<o:p></o:p> Hersen<o:p></o:p> <o:p> </o:p> <o:p> </o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: Deucher, Alexander <Alexander.Deucher@amd.com> Sent: Tuesday, January 15, 2019 12:18 PM To: Wu, Hersen <hersenxs.wu@amd.com>; Alex Deucher <alexdeucher@gmail.com> Cc: Li, Sun peng (Leo) <Sunpeng.Li@amd.com>; amd-gfx@lists.freedesktop.org; Wentland, Harry <Harry.Wentland@amd.com> Subject: Re: [PATCH] drm/amd/display: eDP fast bootup does not work for pre-raven asic<o:p></o:p> </div> </div> <o:p> </o:p> <div id="divtagdefaultwrapper"> So 95f05a3a2e6895ecfd8b4f64b5d6c6 is still valid even with your patch and we should keep it? Thanks<o:p></o:p> <o:p> </o:p> Alex<o:p></o:p> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="divRplyFwdMsg"> From: Wu, Hersen Sent: Tuesday, January 15, 2019 12:04:30 PM To: Alex Deucher Cc: Deucher, Alexander; Li, Sun peng (Leo); <a href="mailto:amd-gfx@lists.freedesktop.org"> amd-gfx@lists.freedesktop.org</a>; Wentland, Harry Subject: RE: [PATCH] drm/amd/display: eDP fast bootup does not work for pre-raven asic <o:p></o:p> <div> <o:p></o:p> </div> </div> <div> <div> My change will NOT revert 95f05a3a2e6895ecfd8b4f64b5d6c6. Thanks Hersen -----Original Message----- From: Alex Deucher <<a href="mailto:alexdeucher@gmail.com">alexdeucher@gmail.com</a>> Sent: Tuesday, January 15, 2019 12:01 PM To: Wu, Hersen <<a href="mailto:hersenxs.wu@amd.com">hersenxs.wu@amd.com</a>> Cc: Deucher, Alexander <<a href="mailto:Alexander.Deucher@amd.com">Alexander.Deucher@amd.com</a>>; Li, Sun peng (Leo) <<a href="mailto:Sunpeng.Li@amd.com">Sunpeng.Li@amd.com</a>>; <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>; Wentland, Harry <<a href="mailto:Harry.Wentland@amd.com">Harry.Wentland@amd.com</a>> Subject: Re: [PATCH] drm/amd/display: eDP fast bootup does not work for pre-raven asic I'm not sure I understand. If we were to apply your proposed patch, could we revert 95f05a3a2e6895ecfd8b4f64b5d6c6 ? Thanks, Alex On Tue, Jan 15, 2019 at 11:57 AM Wu, Hersen <<a href="mailto:hersenxs.wu@amd.com">hersenxs.wu@amd.com</a>> wrote: > > Hi, Alex, > > > > Hersen’s change is for older version of eDP fast boot up ( bios_get_vga_enabled_displays is called). > > Chrome tree source still use bios_get_vga_enabled_displays for fast boot up. > > > > > > Harry’s change is new implementation of eDP fast boot up. > > > > Hersen’s change will not revert Harry’s change. > > > > Thanks, > > Hersen > > > > > > From: Deucher, Alexander <<a href="mailto:Alexander.Deucher@amd.com">Alexander.Deucher@amd.com</a>> > Sent: Tuesday, January 15, 2019 10:43 AM > To: Li, Sun peng (Leo) <<a href="mailto:Sunpeng.Li@amd.com">Sunpeng.Li@amd.com</a>>; > <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> > Cc: Wentland, Harry <<a href="mailto:Harry.Wentland@amd.com">Harry.Wentland@amd.com</a>>; Wu, Hersen > <<a href="mailto:hersenxs.wu@amd.com">hersenxs.wu@amd.com</a>> > Subject: Re: [PATCH] drm/amd/display: eDP fast bootup does not work > for pre-raven asic > > > > Can this patch be reverted with this change? > > > > commit 95f05a3a2e6895ecfd8b4f64b5d6c6cf0b6a3f4a > Author: Alex Deucher <<a href="mailto:alexander.deucher@amd.com">alexander.deucher@amd.com</a>> > Date: Thu Aug 16 15:35:21 2018 -0500 > > drm/amdgpu/display: disable eDP fast boot optimization on DCE8 > > Seems to cause blank screens. > > Bug: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=106940">https://bugs.freedesktop.org/show_bug.cgi?id=106940</a> > Reviewed-by: Harry Wentland <<a href="mailto:harry.wentland@amd.com">harry.wentland@amd.com</a>> > Signed-off-by: Alex Deucher <<a href="mailto:alexander.deucher@amd.com">alexander.deucher@amd.com</a>> > > Other than that, it looks good to me. > > Reviewed-by: Alex Deucher <<a href="mailto:alexander.deucher@amd.com">alexander.deucher@amd.com</a>> > > ________________________________ > > From: amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">amd-gfx-bounces@lists.freedesktop.org</a>> on behalf of > <a href="mailto:sunpeng.li@amd.com">sunpeng.li@amd.com</a> <<a href="mailto:sunpeng.li@amd.com">sunpeng.li@amd.com</a>> > Sent: Monday, January 14, 2019 5:36:15 PM > To: <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> > Cc: Wentland, Harry; Wu, Hersen > Subject: [PATCH] drm/amd/display: eDP fast bootup does not work for > pre-raven asic > > > > From: hersen wu <<a href="mailto:hersenxs.wu@amd.com">hersenxs.wu@amd.com</a>> > > [Why] bios will light up eDP before sw driver loaded. sw driver will > check if eDP lighted up by bios by reading BIOS_SCRATCH_3. If yes, sw > driver will not power down eDP power, phy to save time. > definition of BIOS_SCRATCH_3 are missed for pre-raven asic. this cuase > eDP fast boot up not work. for some eDP panel, even AMD dp tx send > NoVideoStream_flag =1 and dpcd 0x600=2, eDP rx may not handle > properly. this may cause short period flash on screen. > > [How] add definition of BIOS_SCRATCH_3 for all asic > > CC: Harry Wentland <<a href="mailto:harry.wentland@amd.com">harry.wentland@amd.com</a>> > Signed-off-by: hersen wu <<a href="mailto:hersenxs.wu@amd.com">hersenxs.wu@amd.com</a>> > Reviewed-by: Charlene Liu <<a href="mailto:Charlene.Liu@amd.com">Charlene.Liu@amd.com</a>> > Acked-by: Yongqiang Sun <<a href="mailto:yongqiang.sun@amd.com">yongqiang.sun@amd.com</a>> > Acked-by: Leo Li <<a href="mailto:sunpeng.li@amd.com">sunpeng.li@amd.com</a>> > --- > drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.c | 3 +-- > drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c | 2 ++ > drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 2 ++ > drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 2 ++ > drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 1 + > drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c | 2 ++ > 6 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.c > b/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.c > index fdda8aa..d8275ceb 100644 > --- a/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.c > +++ b/drivers/gpu/drm/amd/display/dc/bios/bios_parser_helper.c > @@ -83,8 +83,7 @@ uint32_t bios_get_vga_enabled_displays( { > uint32_t active_disp = 1; > > - if (bios->regs->BIOS_SCRATCH_3) /*follow up with other asic, todo*/ > - active_disp = REG_READ(BIOS_SCRATCH_3) & 0XFFFF; > + active_disp = REG_READ(BIOS_SCRATCH_3) & 0XFFFF; > return active_disp; > } > > diff --git a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c > b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c > index c3f616a..23044e6 100644 > --- a/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c > +++ b/drivers/gpu/drm/amd/display/dc/dce100/dce100_resource.c > @@ -76,6 +76,7 @@ > > #ifndef mmBIOS_SCRATCH_2 > #define mmBIOS_SCRATCH_2 0x05CB > + #define mmBIOS_SCRATCH_3 0x05CC > #define mmBIOS_SCRATCH_6 0x05CF #endif > > @@ -365,6 +366,7 @@ static const struct dce_abm_mask abm_mask = { > #define DCFE_MEM_PWR_CTRL_REG_BASE 0x1b03 > > static const struct bios_registers bios_regs = { > + .BIOS_SCRATCH_3 = mmBIOS_SCRATCH_3, > .BIOS_SCRATCH_6 = mmBIOS_SCRATCH_6 }; > > diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c > b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c > index 7d46eb7..7549ada 100644 > --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c > +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c > @@ -84,6 +84,7 @@ > > #ifndef mmBIOS_SCRATCH_2 > #define mmBIOS_SCRATCH_2 0x05CB > + #define mmBIOS_SCRATCH_3 0x05CC > #define mmBIOS_SCRATCH_6 0x05CF #endif > > @@ -369,6 +370,7 @@ static const struct dce110_clk_src_mask cs_mask = > { }; > > static const struct bios_registers bios_regs = { > + .BIOS_SCRATCH_3 = mmBIOS_SCRATCH_3, > .BIOS_SCRATCH_6 = mmBIOS_SCRATCH_6 }; > > diff --git a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c > b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c > index d930e09..ea3065d6 100644 > --- a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c > +++ b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c > @@ -76,6 +76,7 @@ > > #ifndef mmBIOS_SCRATCH_2 > #define mmBIOS_SCRATCH_2 0x05CB > + #define mmBIOS_SCRATCH_3 0x05CC > #define mmBIOS_SCRATCH_6 0x05CF #endif > > @@ -376,6 +377,7 @@ static const struct dce110_clk_src_mask cs_mask = > { }; > > static const struct bios_registers bios_regs = { > + .BIOS_SCRATCH_3 = mmBIOS_SCRATCH_3, > .BIOS_SCRATCH_6 = mmBIOS_SCRATCH_6 }; > > diff --git a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c > b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c > index 23d7d4d..312a0ae 100644 > --- a/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c > +++ b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c > @@ -442,6 +442,7 @@ struct dce_i2c_hw *dce120_i2c_hw_create( > return dce_i2c_hw; > } > static const struct bios_registers bios_regs = { > + .BIOS_SCRATCH_3 = mmBIOS_SCRATCH_3 + > + NBIO_BASE(mmBIOS_SCRATCH_3_BASE_IDX), > .BIOS_SCRATCH_6 = mmBIOS_SCRATCH_6 + > NBIO_BASE(mmBIOS_SCRATCH_6_BASE_IDX) > }; > > diff --git a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c > b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c > index e0bba0bc..2eca81b 100644 > --- a/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c > +++ b/drivers/gpu/drm/amd/display/dc/dce80/dce80_resource.c > @@ -77,6 +77,7 @@ > > #ifndef mmBIOS_SCRATCH_2 > #define mmBIOS_SCRATCH_2 0x05CB > + #define mmBIOS_SCRATCH_3 0x05CC > #define mmBIOS_SCRATCH_6 0x05CF #endif > > @@ -358,6 +359,7 @@ static const struct dce110_clk_src_mask cs_mask = > { }; > > static const struct bios_registers bios_regs = { > + .BIOS_SCRATCH_3 = mmBIOS_SCRATCH_3, > .BIOS_SCRATCH_6 = mmBIOS_SCRATCH_6 }; > > -- > 2.7.4 > > _______________________________________________ > amd-gfx mailing list > <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> > <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> > > _______________________________________________ > amd-gfx mailing list > <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> > <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><o:p></o:p> </div> </div> </div> </body> </html>