<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">Series is:</p>
<p style="margin-top:0;margin-bottom:0">Reviewed-by: Alex Deucher <alexander.deucher@amd.com><br>
</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Evan Quan <evan.quan@amd.com><br>
<b>Sent:</b> Wednesday, January 16, 2019 1:16:15 AM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org<br>
<b>Cc:</b> Quan, Evan<br>
<b>Subject:</b> [PATCH 2/2] drm/amdgpu: fix wrong APU judgement</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Fix the APU judgement to make it really work as expected.<br>
<br>
Change-Id: Iedc7d280e2bb68dd1b3732adb3b36ff9b05d84af<br>
Signed-off-by: Evan Quan <evan.quan@amd.com><br>
---<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 4 ++--<br>
1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c<br>
index 42078607168f..931cfd947958 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c<br>
@@ -2483,7 +2483,7 @@ int amdgpu_pm_sysfs_init(struct amdgpu_device *adev)<br>
return ret;<br>
}<br>
/* PCIe Perf counters won't work on APU nodes */<br>
- if (adev->flags & !AMD_IS_APU) {<br>
+ if (!(adev->flags & AMD_IS_APU)) {<br>
ret = device_create_file(adev->dev, &dev_attr_pcie_bw);<br>
if (ret) {<br>
DRM_ERROR("failed to create device file pcie_bw\n");<br>
@@ -2546,7 +2546,7 @@ void amdgpu_pm_sysfs_fini(struct amdgpu_device *adev)<br>
device_remove_file(adev->dev,<br>
&dev_attr_pp_od_clk_voltage);<br>
device_remove_file(adev->dev, &dev_attr_gpu_busy_percent);<br>
- if (adev->flags & !AMD_IS_APU)<br>
+ if (!(adev->flags & AMD_IS_APU))<br>
device_remove_file(adev->dev, &dev_attr_pcie_bw);<br>
if ((adev->asic_type >= CHIP_VEGA10) &&<br>
!(adev->flags & AMD_IS_APU))<br>
-- <br>
2.20.1<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br>
</div>
</span></font></div>
</body>
</html>