<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Am 29.01.19 um 22:54 schrieb Marek
Olšák:<br>
</div>
<blockquote type="cite"
cite="mid:CAAxE2A4GaY4-osO6GfC-zG9ofxu2wjWZJ74Jds1ntqXZba_vQw@mail.gmail.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<div dir="ltr">
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Tue, Jan 29, 2019 at 3:01
AM Christian König <<a
href="mailto:ckoenig.leichtzumerken@gmail.com"
target="_blank" moz-do-not-send="true">ckoenig.leichtzumerken@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid
rgb(204,204,204);padding-left:1ex">Am 28.01.19 um 22:52
schrieb Marek Olšák:<br>
> From: Marek Olšák <<a
href="mailto:marek.olsak@amd.com" target="_blank"
moz-do-not-send="true">marek.olsak@amd.com</a>><br>
><br>
> Normal syncobjs signal when an IB finishes. Start
syncobjs signal when<br>
> an IB starts.<br>
<br>
That approach has quite a number of problems (for example
you can't <br>
allocate memory at this point).<br>
</blockquote>
<div><br>
</div>
<div>Even if I drop this patch, can you describe all the
problems with it? Andrey and I would like to understand
this.<br>
</div>
</div>
</div>
</blockquote>
<br>
<blockquote type="cite">amdgpu_mn_lock(p->mn);<br>
...<br>
r = drm_syncobj_create(&syncobj, 0,...<br>
</blockquote>
<br>
You can't allocate memory while holding the MN lock, so calling
drm_syncobj_create() here is forbidden.<br>
<br>
<blockquote type="cite">r = drm_syncobj_get_handle(p->filp,
syncobj,...<br>
</blockquote>
<br>
This can fail which would result in a syncobj which is never
signaled nor freed.<br>
<br>
Regards,<br>
Christian.<br>
<br>
<blockquote type="cite"
cite="mid:CAAxE2A4GaY4-osO6GfC-zG9ofxu2wjWZJ74Jds1ntqXZba_vQw@mail.gmail.com">
<div dir="ltr">
<div class="gmail_quote">
<div><br>
</div>
<div>Thanks,</div>
<div>Marek</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
amd-gfx mailing list
<a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a>
</pre>
</blockquote>
<br>
</body>
</html>