<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Thanks, I will update, add your RB and push.</p>
<p>Andrey<br>
</p>
<div class="moz-cite-prefix">On 2/3/19 10:51 AM, Koenig, Christian wrote:<br>
</div>
<blockquote type="cite" cite="mid:2d32f38c-5ea7-d967-2a5d-bdc11fbb5e7b@amd.com">
<blockquote type="cite" style="color: #000000;">
<pre class="moz-quote-pre" wrap="">@@ -1090,6 +1091,14 @@ static int amdgpu_cs_process_fence_dep(struct amdgpu_cs_parser *p,
fence = amdgpu_ctx_get_fence(ctx, entity,
deps[i].handle);
+
+ if (chunk->chunk_id == AMDGPU_CHUNK_ID_SCHEDULED_DEPENDENCIES) {
+ struct drm_sched_fence *s_fence = to_drm_sched_fence(fence);
+
+ dma_fence_put(fence);
+ fence = dma_fence_get(&s_fence->scheduled);
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">You need to change the order here or otherwise the dma_fence_put could
destroy the fence we want.
Apart from that looks really good to me,
Christian.
</pre>
</blockquote>
</body>
</html>