<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<br>
<br>
<div style="color: rgb(185, 185, 185);">
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com><br>
<b>Sent:</b> February 4, 2019 10:45 AM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org<br>
<b>Cc:</b> Sun, Yongqiang<br>
<b>Subject:</b> [PATCH 15/35] drm/amd/display: pass vline_config parameter by reference.</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">From: Yongqiang Sun <yongqiang.sun@amd.com><br>
<br>
Change-Id: Icfe018c7579ad2b3ef65195f578b8e44422d53f3<br>
Signed-off-by: Yongqiang Sun <yongqiang.sun@amd.com><br>
Reviewed-by: Aric Cyr <Aric.Cyr@amd.com><br>
Acked-by: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com><br>
---<br>
drivers/gpu/drm/amd/display/dc/core/dc.c | 4 ++--<br>
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.c | 8 ++++----<br>
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.h | 2 +-<br>
drivers/gpu/drm/amd/display/dc/inc/hw/timing_generator.h | 2 +-<br>
4 files changed, 8 insertions(+), 8 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c<br>
index e0ac009f00ab..d8579b207300 100644<br>
--- a/drivers/gpu/drm/amd/display/dc/core/dc.c<br>
+++ b/drivers/gpu/drm/amd/display/dc/core/dc.c<br>
@@ -1560,11 +1560,11 @@ static void commit_planes_do_stream_update(struct dc *dc,<br>
<br>
if (stream_update->vline0_config && pipe_ctx->stream_res.tg->funcs->program_vline_interrupt)<br>
pipe_ctx->stream_res.tg->funcs->program_vline_interrupt(<br>
- pipe_ctx->stream_res.tg, VLINE0, stream->vline0_config);<br>
+ pipe_ctx->stream_res.tg, VLINE0, &stream->vline0_config);<br>
<br>
if (stream_update->vline1_config && pipe_ctx->stream_res.tg->funcs->program_vline_interrupt)<br>
pipe_ctx->stream_res.tg->funcs->program_vline_interrupt(<br>
- pipe_ctx->stream_res.tg, VLINE1, stream->vline1_config);<br>
+ pipe_ctx->stream_res.tg, VLINE1, &stream->vline1_config);<br>
<br>
if ((stream_update->hdr_static_metadata && !stream->use_dynamic_meta) ||<br>
stream_update->vrr_infopacket ||<br>
diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.c<br>
index 1d4f9b48ed7d..cefa322df8a6 100644<br>
--- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.c<br>
+++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.c<br>
@@ -95,19 +95,19 @@ static void optc1_disable_stereo(struct timing_generator *optc)<br>
void optc1_program_vline_interrupt(<br>
struct timing_generator *optc,<br>
enum vline_select vline,<br>
- struct vline_config vline_config)<br>
+ const struct vline_config *vline_config)<br>
{<br>
struct optc *optc1 = DCN10TG_FROM_TG(optc);<br>
<br>
switch (vline) {<br>
case VLINE0:<br>
REG_SET_2(OTG_VERTICAL_INTERRUPT0_POSITION, 0,<br>
- OTG_VERTICAL_INTERRUPT0_LINE_START, vline_config.start_line,<br>
- OTG_VERTICAL_INTERRUPT0_LINE_END, vline_config.end_line);<br>
+ OTG_VERTICAL_INTERRUPT0_LINE_START, vline_config->start_line,<br>
+ OTG_VERTICAL_INTERRUPT0_LINE_END, vline_config->end_line);<br>
break;<br>
case VLINE1:<br>
REG_SET(OTG_VERTICAL_INTERRUPT1_POSITION, 0,<br>
- OTG_VERTICAL_INTERRUPT1_LINE_START, vline_config.start_line);<br>
+ OTG_VERTICAL_INTERRUPT1_LINE_START, vline_config->start_line);<br>
break;<br>
default:<br>
break;<br>
diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.h b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.h<br>
index 8eb71c0160a7..b34c8a240598 100644<br>
--- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.h<br>
+++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_optc.h<br>
@@ -485,7 +485,7 @@ void optc1_program_timing(<br>
<br>
void optc1_program_vline_interrupt(struct timing_generator *optc,<br>
enum vline_select vline,<br>
- struct vline_config vline_config);<br>
+ const struct vline_config *vline_config);<br>
<br>
void optc1_program_global_sync(<br>
struct timing_generator *optc);<br>
diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/timing_generator.h b/drivers/gpu/drm/amd/display/dc/inc/hw/timing_generator.h<br>
index df64cf73ceb9..d22a406c19c0 100644<br>
--- a/drivers/gpu/drm/amd/display/dc/inc/hw/timing_generator.h<br>
+++ b/drivers/gpu/drm/amd/display/dc/inc/hw/timing_generator.h<br>
@@ -151,7 +151,7 @@ struct timing_generator_funcs {<br>
bool use_vbios);<br>
void (*program_vline_interrupt)(struct timing_generator *optc,<br>
enum vline_select vline,<br>
- struct vline_config vline_config);<br>
+ const struct vline_config *vline_config);<br>
bool (*enable_crtc)(struct timing_generator *tg);<br>
bool (*disable_crtc)(struct timing_generator *tg);<br>
bool (*is_counter_moving)(struct timing_generator *tg);<br>
-- <br>
2.17.1<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk545101" class="OWAAutoLink" previewremoved="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a>
<div id="LPBorder_GT_15492952949000.33470954385925944" style="margin-bottom: 20px; overflow: auto; width: 100%; text-indent: 0px;">
<table id="LPContainer_15492952948980.28840650540887725" style="width: 90%; background-color: rgb(37, 37, 37); position: relative; overflow: auto; padding-top: 20px; padding-bottom: 20px; margin-top: 20px; border-top: 1px dotted rgb(64, 64, 64); border-bottom: 1px dotted rgb(64, 64, 64);" role="presentation" cellspacing="0">
<tbody>
<tr style="border-spacing: 0px;" valign="top">
<td id="TextCell_15492952948990.18264087239542548" style="vertical-align: top; position: relative; padding: 0px; display: table-cell;" colspan="2">
<div id="LPRemovePreviewContainer_15492952948990.025164069854981763"></div>
<div id="LPTitle_15492952948990.15713982790708425" style="top: 0px; color: rgb(46, 162, 255); font-weight: 400; font-size: 21px; font-family: "wf_segoe-ui_light", "Segoe UI Light", "Segoe WP Light", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; line-height: 21px;">
<a id="LPUrlAnchor_15492952948990.6137017105389825" style="text-decoration: none;" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank">amd-gfx Info Page - freedesktop.org</a></div>
<div id="LPMetadata_15492952948990.2929248586278588" style="margin: 10px 0px 16px; color: rgb(185, 185, 185); font-weight: 400; font-family: "wf_segoe-ui_normal", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 14px;">
lists.freedesktop.org</div>
<div id="LPDescription_15492952949000.8198784761872338" style="display: block; color: rgb(185, 185, 185); font-weight: 400; font-family: "wf_segoe-ui_normal", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 20px; max-height: 100px; overflow: hidden;">
To see the collection of prior postings to the list, visit the amd-gfx Archives.. Using amd-gfx: To post a message to all the list members, send email to amd-gfx@lists.freedesktop.org. You can subscribe to the list, or change your existing subscription, in
the sections below.</div>
</td>
</tr>
</tbody>
</table>
</div>
<br>
</div>
</span></font></div>
</div>
</div>
</body>
</html>