<div dir="ltr"><div>HI Alex,</div><div><br></div><div>I will check with your patch. if it doesn't work i will raise bug .</div><div><br></div><div>Regards,</div><div>Sk shahul.<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Feb 21, 2019 at 12:01 PM Alex Deucher <<a href="mailto:alexdeucher@gmail.com">alexdeucher@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Wed, Feb 20, 2019 at 11:56 PM shahul hameed<br>
<<a href="mailto:shahulhameed.481@gmail.com" target="_blank">shahulhameed.481@gmail.com</a>> wrote:<br>
><br>
> Hi All,<br>
><br>
> I did below exoeriments:<br>
><br>
> -> S2idle is working in software rendering mode(disable AMDGPU driver).<br>
><br>
> -> For experiment purpose i commented suspend/resume calls of amdgpu driver, in this case S2idle worked.<br>
><br>
> With above experiments it is clear that my platform supports s2idel.<br>
> Some issue in AMDGPU suspend/resume sequence for s2idle.<br>
> So can you please help me.<br>
<br>
I'd suggest filing a bug (<a href="https://bugs.freedesktop.org" rel="noreferrer" target="_blank">https://bugs.freedesktop.org</a>) and attaching<br>
your full dmesg output. I'm not too familiar with s2idle and what<br>
pmops paths it uses. I suspect what is happening is that the power is<br>
not getting fully cut the the device when s2idle is invoked, and it's<br>
left in a bad state on resume. Maybe something like the attached<br>
patch might help. That said, if the platform is not properly cutting<br>
power to the device at s2idle time, you probably aren't saving any<br>
power anyway.<br>
<br>
Alex<br>
<br>
><br>
> Thanks & Regards,<br>
> Sk shahul.<br>
><br>
> On Thu, Feb 21, 2019 at 3:32 AM Alex Deucher <<a href="mailto:alexdeucher@gmail.com" target="_blank">alexdeucher@gmail.com</a>> wrote:<br>
>><br>
>> On Wed, Feb 20, 2019 at 4:59 PM shahul hameed<br>
>> <<a href="mailto:shahulhameed.481@gmail.com" target="_blank">shahulhameed.481@gmail.com</a>> wrote:<br>
>> ><br>
>> > Hi<br>
>> ><br>
>> > I am facing below issue. Can any one please help me to resolve it.<br>
>><br>
>> As I mentioned previously, please make sure the platform supports<br>
>> s2idle and that it is enabled in the sbios. Does s2idle work on other<br>
>> devices and the platform itself?<br>
>><br>
>> Alex<br>
>><br>
>> ><br>
>> > Regards,<br>
>> > Sk shahul<br>
>> ><br>
>> > ---------- Forwarded message ---------<br>
>> > From: shahul hameed <<a href="mailto:shahulhameed.481@gmail.com" target="_blank">shahulhameed.481@gmail.com</a>><br>
>> > Date: Wed, Feb 20, 2019, 3:13 PM<br>
>> > Subject: s2idle not working<br>
>> > To: <<a href="mailto:shirish.s@amd.com" target="_blank">shirish.s@amd.com</a>><br>
>> ><br>
>> ><br>
>> > Hi Shirish<br>
>> ><br>
>> > I am porting Android_N and keenel 4.19.2 to Ryzen platform. Graphic card is gfx9.<br>
>> > Porting is done successfully. Now i am working on suspend/resume.<br>
>> > Suspend/resume is working fine in deep mode.<br>
>> > But suspend/resume is not working in s2idle (Suspend to idle) mode.<br>
>> ><br>
>> > during resume i found error in gpu driver.<br>
>> ><br>
>> > [ 105.862161] [drm:gfx_v9_0_hw_init [amdgpu]] *ERROR* KCQ enable failed (scratch(0xC040)=0xCAFEDEAD)<br>
>> > [ 105.862187] [drm:amdgpu_device_ip_resume_phase2 [amdgpu]] *ERROR* resume of IP block <gfx_v9_0> failed -22<br>
>> > [ 105.862210] [drm:amdgpu_device_resume [amdgpu]] *ERROR* amdgpu_device_ip_resume failed (-22).<br>
>> > [ 105.862215] dpm_run_callback(): pci_pm_resume+0x0/0xd6 returns -22<br>
>> > [ 105.862345] PM: Device 0000:03:00.0 failed to resume async: error -22<br>
>> ><br>
>> > same issue is reproduced with ubuntu16.04.<br>
>> ><br>
>> > Can you please help me to resolve this issue.<br>
>> > Thanks in Advance,<br>
>> > Regards,<br>
>> > Sk shahul.<br>
>> > _______________________________________________<br>
>> > amd-gfx mailing list<br>
>> > <a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a><br>
>> > <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br>
</blockquote></div>