<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=gb2312"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="#0563C1" vlink="#954F72"> <div class="WordSection1"> Okay, Thanks for the clarifying. Yes, we will need the interrupt handler. So let’s just keep the set function as is.<o:p></o:p> <o:p> </o:p> Regards, Hawking<o:p></o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm"> From: Pan, Xinhui <Xinhui.Pan@amd.com> Sent: 2019年3月1日 16:18 To: Zhang, Hawking <Hawking.Zhang@amd.com>; brahma_sw_dev <brahma_sw_dev@amd.com>; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander <Alexander.Deucher@amd.com> Subject: RE: [patch] ras fix patch set <o:p></o:p> </div> </div> <o:p> </o:p> #1 can’t drop it, Need install irq handler. irq_get will fail it ->set is empty.<o:p></o:p> <o:p> </o:p> #4, move all codes in the {}… I did not notice it too….<o:p></o:p> <o:p> </o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm"> From: Zhang, Hawking <<a href="mailto:Hawking.Zhang@amd.com">Hawking.Zhang@amd.com</a>> Sent: 2019年3月1日 14:57 To: Pan, Xinhui <<a href="mailto:Xinhui.Pan@amd.com">Xinhui.Pan@amd.com</a>>; brahma_sw_dev <<a href="mailto:brahma_sw_dev@amd.com">brahma_sw_dev@amd.com</a>>; <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> Cc: Deucher, Alexander <<a href="mailto:Alexander.Deucher@amd.com">Alexander.Deucher@amd.com</a>> Subject: RE: [patch] ras fix patch set <o:p></o:p> </div> </div> <o:p> </o:p> Patch #1<o:p></o:p> <o:p> </o:p> Can you just drop the whole function (sdma_v4_0_ecc_irq_funcs) ?<o:p></o:p> <o:p> </o:p> Patch #4<o:p></o:p> <o:p> </o:p> What the patch actually do seems doesn’t match with the description. I only see you adjust some code alignment in patch #4, anything I missed?<o:p></o:p> <o:p> </o:p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm"> From: Pan, Xinhui <<a href="mailto:Xinhui.Pan@amd.com">Xinhui.Pan@amd.com</a>> Sent: 2019年3月1日 14:06 To: brahma_sw_dev <<a href="mailto:brahma_sw_dev@amd.com">brahma_sw_dev@amd.com</a>>; <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> Cc: Zhang, Hawking <<a href="mailto:Hawking.Zhang@amd.com">Hawking.Zhang@amd.com</a>>; Deucher, Alexander <<a href="mailto:Alexander.Deucher@amd.com">Alexander.Deucher@amd.com</a>> Subject: [patch] ras fix patch set <o:p></o:p> </div> </div> <o:p> </o:p> Hi,<o:p></o:p> This is to fix some issues reported recently.<o:p></o:p> 1) no need to do sdma irq setting. Ras ta do it.<o:p></o:p> 2) gpu reset is not stable on some boards, so make amdgpu_ras_reset_gpu a empty function.<o:p></o:p> 3) fix build warnings.<o:p></o:p> 4) ta might be missing, in such case, hit null pointer.<o:p></o:p> <o:p> </o:p> xinhui pan (4):<o:p></o:p> drm/amdgpu: do not set sdma ecc interrupt<o:p></o:p> drm/amdgpu: skip gpu reset when ras error occured<o:p></o:p> drm/amdgpu: fix compile warning<o:p></o:p> drm/amdgpu: fix NULL pointer when ta is missing<o:p></o:p> <o:p> </o:p> drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +-<o:p></o:p> drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 1 -<o:p></o:p> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 5 +++--<o:p></o:p> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 3 +++<o:p></o:p> drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +-<o:p></o:p> drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 12 ++++++------<o:p></o:p> drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 11 -----------<o:p></o:p> 7 files changed, 14 insertions(+), 22 deletions(-)<o:p></o:p> </div> </body> </html>