<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Reviewed-by: Alex Deucher <alexander.deucher@amd.com><br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Tom St Denis <tstdenis82@gmail.com><br>
<b>Sent:</b> Tuesday, March 5, 2019 10:17 AM<br>
<b>To:</b> amd-gfx mailing list<br>
<b>Subject:</b> Re: [PATCH] drm/amd/amdgpu: Add ENGINE_CNTL register to vcn10 headers</font>
<div> </div>
</div>
<div>
<div dir="ltr">Hi,
<div><br>
</div>
<div>Alex can I get an RB on this :-)</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Tom</div>
</div>
<br>
<div class="x_gmail_quote">
<div dir="ltr" class="x_gmail_attr">On Mon, Mar 4, 2019 at 10:59 AM StDenis, Tom <<a href="mailto:Tom.StDenis@amd.com">Tom.StDenis@amd.com</a>> wrote:<br>
</div>
<blockquote class="x_gmail_quote" style="margin:0px 0px 0px 0.8ex; border-left:1px solid rgb(204,204,204); padding-left:1ex">
Signed-off-by: Tom St Denis <<a href="mailto:tom.stdenis@amd.com" target="_blank">tom.stdenis@amd.com</a>><br>
---<br>
 drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_offset.h  | 2 ++<br>
 drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_sh_mask.h | 5 +++++<br>
 2 files changed, 7 insertions(+)<br>
<br>
diff --git a/drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_offset.h b/drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_offset.h<br>
index 442ca7c471a5..6109f5ad25ad 100644<br>
--- a/drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_offset.h<br>
+++ b/drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_offset.h<br>
@@ -141,6 +141,8 @@<br>
 #define mmUVD_GPCOM_VCPU_DATA0_BASE_IDX                                                                1<br>
 #define mmUVD_GPCOM_VCPU_DATA1                                                                         0x03c5<br>
 #define mmUVD_GPCOM_VCPU_DATA1_BASE_IDX                                                                1<br>
+#define mmUVD_ENGINE_CNTL                                                                              0x03c6<br>
+#define mmUVD_ENGINE_CNTL_BASE_IDX                                                                     1<br>
 #define mmUVD_UDEC_DBW_UV_ADDR_CONFIG                                                                  0x03d2<br>
 #define mmUVD_UDEC_DBW_UV_ADDR_CONFIG_BASE_IDX                                                         1<br>
 #define mmUVD_UDEC_ADDR_CONFIG                                                                         0x03d3<br>
diff --git a/drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_sh_mask.h b/drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_sh_mask.h<br>
index 63457f9df4c5..f84bed6eecb9 100644<br>
--- a/drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_sh_mask.h<br>
+++ b/drivers/gpu/drm/amd/include/asic_reg/vcn/vcn_1_0_sh_mask.h<br>
@@ -312,6 +312,11 @@<br>
 //UVD_GPCOM_VCPU_DATA1<br>
 #define UVD_GPCOM_VCPU_DATA1__DATA1__SHIFT                                                                    0x0<br>
 #define UVD_GPCOM_VCPU_DATA1__DATA1_MASK                                                                      0xFFFFFFFFL<br>
+//UVD_ENGINE_CNTL<br>
+#define UVD_ENGINE_CNTL__ENGINE_START_MASK 0x1<br>
+#define UVD_ENGINE_CNTL__ENGINE_START__SHIFT 0x0<br>
+#define UVD_ENGINE_CNTL__ENGINE_START_MODE_MASK 0x2<br>
+#define UVD_ENGINE_CNTL__ENGINE_START_MODE__SHIFT 0x1<br>
 //UVD_UDEC_DBW_UV_ADDR_CONFIG<br>
 #define UVD_UDEC_DBW_UV_ADDR_CONFIG__NUM_PIPES__SHIFT                                                         0x0<br>
 #define UVD_UDEC_DBW_UV_ADDR_CONFIG__PIPE_INTERLEAVE_SIZE__SHIFT                                              0x3<br>
-- <br>
2.17.2<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
<a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></blockquote>
</div>
</div>
</body>
</html>