<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=Windows-1252"> </head> <body text="#000000" bgcolor="#FFFFFF"> <p>Oops. I submitted it moments ago. Thanks for your catch anyway.</p> <p><br> </p> <p>Eric</p> <p><br> </p> <div class="moz-cite-prefix">On 2019-03-06 11:34 a.m., William Lewis wrote:<br> </div> <blockquote type="cite" cite="mid:MWHPR17MB0943D3796778E3FEC71B3CE7C8730@MWHPR17MB0943.namprd17.prod.outlook.com"> <p>Typo in patch description: s/disalbed/disabled/<br> </p> <p><br> </p> <div class="moz-cite-prefix">On 3/6/19 10:11 AM, Deucher, Alexander wrote:<br> </div> <blockquote type="cite" cite="mid:BN6PR12MB18092777ADEAC0257140E23DF7730@BN6PR12MB1809.namprd12.prod.outlook.com"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Add a line like:</div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Fixes: <font size="2"><span style="font-size:11pt">9032ea09e2d2ef</span></font> <font size="2"> (<span style="font-size:11pt">"drm/amdkfd: add RAS ECC event support</span></font>")</div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> With that added:</div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Reviewed-by: Alex Deucher <a class="moz-txt-link-rfc2396E" href="mailto:alexander.deucher@amd.com" moz-do-not-send="true"> <alexander.deucher@amd.com></a><br> </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> amd-gfx <a class="moz-txt-link-rfc2396E" href="mailto:amd-gfx-bounces@lists.freedesktop.org" moz-do-not-send="true"> <amd-gfx-bounces@lists.freedesktop.org></a> on behalf of Huang, JinHuiEric <a class="moz-txt-link-rfc2396E" href="mailto:JinHuiEric.Huang@amd.com" moz-do-not-send="true"> <JinHuiEric.Huang@amd.com></a><br> <b>Sent:</b> Wednesday, March 6, 2019 10:59 AM<br> <b>To:</b> <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org" moz-do-not-send="true"> amd-gfx@lists.freedesktop.org</a><br> <b>Cc:</b> Huang, JinHuiEric<br> <b>Subject:</b> [PATCH] drm/amdkfd: fix a compiling error when CONFIG_HSA_AMD disalbed</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">It fixes a commpiling error on commit<br> 9032ea09e2d2ef0d10e5cd793713bf2eb21643c5<br> drm/amdkfd: add RAS ECC event support<br> <br> Change-Id: I8792767726e28eed3a3fcf9072f608701be13c79<br> Signed-off-by: Eric Huang <a class="moz-txt-link-rfc2396E" href="mailto:JinhuiEric.Huang@amd.com" moz-do-not-send="true"> <JinhuiEric.Huang@amd.com></a><br> ---<br> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 4 ++++<br> 1 file changed, 4 insertions(+)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c<br> index fe1d736..acf8ae0 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c<br> @@ -640,4 +640,8 @@ int kgd2kfd_post_reset(struct kfd_dev *kfd)<br> void kgd2kfd_interrupt(struct kfd_dev *kfd, const void *ih_ring_entry)<br> {<br> }<br> +<br> +void kgd2kfd_set_sram_ecc_flag(struct kfd_dev *kfd)<br> +{<br> +}<br> #endif<br> -- <br> 2.7.4<br> <br> _______________________________________________<br> amd-gfx mailing list<br> <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org" moz-do-not-send="true">amd-gfx@lists.freedesktop.org</a><br> <a href="https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7C%7C2cf93d5576b848c6d66708d6a24e5eb2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636874854807263322&sdata=AV62VQT1o%2F6gVK1eHdzGT4vmCEJveX6C26npgyRgZtY%3D&reserved=0" originalsrc="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" shash="wJ7Jx6w2ducSGOBwKsXyGKjFfSvEUMlArajXY4z3oxN43BS6sc85sBXhf5ystW7OmVSYn/MhseAKCCxTVigTYSqIKZEgJc3LPytTH987QTPIuwF3zi2j7o+ZVFbRdnKzLHJKiN6ENrjUsFBwgw2HC3JM3NdOrxX+C5xpKxKpMnk=" moz-do-not-send="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></div> </span></font></div> <br> <fieldset class="mimeAttachmentHeader"></fieldset> <pre class="moz-quote-pre" wrap="">_______________________________________________ amd-gfx mailing list <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org" moz-do-not-send="true">amd-gfx@lists.freedesktop.org</a> <a class="moz-txt-link-freetext" href="https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7C%7C2cf93d5576b848c6d66708d6a24e5eb2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636874854807293349&sdata=7nutYNQv0XODz%2BUzQTTbIrahZI%2B6%2BG9cETOEkBnUAU4%3D&reserved=0" moz-do-not-send="true">https://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=02%7C01%7C%7C2cf93d5576b848c6d66708d6a24e5eb2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636874854807293349&sdata=7nutYNQv0XODz%2BUzQTTbIrahZI%2B6%2BG9cETOEkBnUAU4%3D&reserved=0</a></pre> </blockquote> <br> <fieldset class="mimeAttachmentHeader"></fieldset> <pre class="moz-quote-pre" wrap="">_______________________________________________ amd-gfx mailing list <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></pre> </blockquote> </body> </html>