<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Reviewed-by: Alex Deucher <alexander.deucher@amd.com><br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Evan Quan <evan.quan@amd.com><br>
<b>Sent:</b> Thursday, March 7, 2019 2:00 AM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org<br>
<b>Cc:</b> Deucher, Alexander; Pan, Xinhui; Quan, Evan; Zhang, Hawking<br>
<b>Subject:</b> [PATCH] drm/amdgpu: fix ras parameter descriptions</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">The descriptions of modinfo wrongly show two parameters<br>
for each feature(see below). This patch can fix this<br>
incorrect outputs.<br>
<br>
parm: amdgpu_ras_enable:Enable RAS features on the GPU (0 = disable, 1 = enable, -1 = auto (default))<br>
parm: ras_enable:int<br>
parm: amdgpu_ras_mask:Mask of RAS features to enable (default 0xffffffff), only valid when ras_enable == 1<br>
parm: ras_mask:uint<br>
<br>
Change-Id: I04f7e505cecca991f196802befd2006dc49b3dcf<br>
Signed-off-by: Evan Quan <evan.quan@amd.com><br>
---<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 8 ++++----<br>
1 file changed, 4 insertions(+), 4 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c<br>
index 38dbf6115c15..e0a7712d5d7b 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c<br>
@@ -512,18 +512,18 @@ MODULE_PARM_DESC(emu_mode, "Emulation mode, (1 = enable, 0 = disable)");<br>
module_param_named(emu_mode, amdgpu_emu_mode, int, 0444);<br>
<br>
/*<br>
- * DOC: amdgpu_ras_enable (int)<br>
+ * DOC: ras_enable (int)<br>
* Enable RAS features on the GPU (0 = disable, 1 = enable, -1 = auto (default))<br>
*/<br>
-MODULE_PARM_DESC(amdgpu_ras_enable, "Enable RAS features on the GPU (0 = disable, 1 = enable, -1 = auto (default))");<br>
+MODULE_PARM_DESC(ras_enable, "Enable RAS features on the GPU (0 = disable, 1 = enable, -1 = auto (default))");<br>
module_param_named(ras_enable, amdgpu_ras_enable, int, 0444);<br>
<br>
/**<br>
- * DOC: amdgpu_ras_mask (uint)<br>
+ * DOC: ras_mask (uint)<br>
* Mask of RAS features to enable (default 0xffffffff), only valid when ras_enable == 1<br>
* See the flags in drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h<br>
*/<br>
-MODULE_PARM_DESC(amdgpu_ras_mask, "Mask of RAS features to enable (default 0xffffffff), only valid when ras_enable == 1");<br>
+MODULE_PARM_DESC(ras_mask, "Mask of RAS features to enable (default 0xffffffff), only valid when ras_enable == 1");<br>
module_param_named(ras_mask, amdgpu_ras_mask, uint, 0444);<br>
<br>
<br>
-- <br>
2.21.0<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></div>
</span></font></div>
</body>
</html>