<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Acked-by: Alex Deucher <alexander.deucher@amd.com><br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Michel Dänzer <michel@daenzer.net><br>
<b>Sent:</b> Friday, March 8, 2019 5:51 AM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org<br>
<b>Subject:</b> [PATCH xf86-video-ati] Revert "glamor: Avoid glamor_create_pixmap for pixmaps backing windows"</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">From: Michel Dänzer <michel.daenzer@amd.com><br>
<br>
This reverts commit 274703087f80342f51fa69c935bb9a1cb0c4ae47.<br>
<br>
Reports of visual corruption were bisected to this, e.g.<br>
<a href="https://bugs.archlinux.org/task/61941">https://bugs.archlinux.org/task/61941</a> . I can reproduce this with Turks,<br>
but not with Bonaire. I assume it's a Mesa/glamor bug, but let's revert<br>
for now.<br>
<br>
Signed-off-by: Michel Dänzer <michel.daenzer@amd.com><br>
---<br>
src/radeon_glamor.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/radeon_glamor.c b/src/radeon_glamor.c<br>
index 3e676f2dc..f1098381e 100644<br>
--- a/src/radeon_glamor.c<br>
+++ b/src/radeon_glamor.c<br>
@@ -238,7 +238,7 @@ radeon_glamor_create_pixmap(ScreenPtr screen, int w, int h, int depth,<br>
if (info->shadow_primary) {<br>
if (usage != CREATE_PIXMAP_USAGE_BACKING_PIXMAP)<br>
return fbCreatePixmap(screen, w, h, depth, usage);<br>
- } else if (usage != CREATE_PIXMAP_USAGE_BACKING_PIXMAP) {<br>
+ } else {<br>
pixmap = glamor_create_pixmap(screen, w, h, depth, usage);<br>
if (pixmap)<br>
return pixmap;<br>
-- <br>
2.20.1<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></div>
</span></font></div>
</body>
</html>