<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;" dir="ltr"> <p style="margin-top:0;margin-bottom:0"><br> </p> <div style="color: rgb(0, 0, 0);"> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Dan Carpenter <dan.carpenter@oracle.com><br> <b>Sent:</b> Thursday, March 21, 2019 5:19 PM<br> <b>To:</b> Deucher, Alexander; Wang, Kevin(Yang)<br> <b>Cc:</b> Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter; Huang, Ray; Gao, Likun; Gui, Jack; amd-gfx@lists.freedesktop.org; kernel-janitors@vger.kernel.org<br> <b>Subject:</b> [PATCH] drm/amd/powerplay: Off by one in vega20_get_smu_msg_index()</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">The > should be >= so that we don't read one element beyond the end of<br> the vega20_message_map[] array.<br> <br> Fixes: 3ec3c931489f ("drm/amd/powerplay: implement smu vega20_message_map for vega20")<br> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com><br> ---<br> drivers/gpu/drm/amd/powerplay/vega20_ppt.c | 3 ++-<br> 1 file changed, 2 insertions(+), 1 deletion(-)<br> <br> diff --git a/drivers/gpu/drm/amd/powerplay/vega20_ppt.c b/drivers/gpu/drm/amd/powerplay/vega20_ppt.c<br> index 7e9e8ad9a300..31cd7b9d4dad 100644<br> --- a/drivers/gpu/drm/amd/powerplay/vega20_ppt.c<br> +++ b/drivers/gpu/drm/amd/powerplay/vega20_ppt.c<br> @@ -132,7 +132,8 @@ static int vega20_message_map[SMU_MSG_MAX_COUNT] = {<br> static int vega20_get_smu_msg_index(struct smu_context *smc, uint32_t index)<br> {<br> int val;<br> - if (index > SMU_MSG_MAX_COUNT)<br> +<br> + if (index >= SMU_MSG_MAX_COUNT)<br> return -EINVAL;<br> <br> val = vega20_message_map[index];</div> <div class="PlainText"><br> </div> <div class="PlainText">Reviewed-by: Kevin Wang <kevin1.wang@amd.com><br> -- <br> 2.17.1<br> <br> </div> </span></font></div> </div> </div> </body> </html>