<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Sure no problem.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Acked-by: Alex Deucher <alexander.deucher@amd.com><br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Quan, Evan<br>
<b>Sent:</b> Wednesday, March 27, 2019 9:55 PM<br>
<b>To:</b> Quan, Evan; amd-gfx@lists.freedesktop.org; Deucher, Alexander<br>
<b>Cc:</b> Russell, Kent<br>
<b>Subject:</b> RE: [PATCH] drm/amd/powerplay: check for invalid profile mode before switching</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">It's kind of an improvement of the previous commit<br>
drm/amd/powerplay: update current profile mode only when it's really applied<br>
<br>
No need to update current profile mode if the new profile mode<br>
does not take effect in fact.<br>
<br>
Maybe @Deucher, Alexander can help to combine them as one.<br>
<br>
Regards,<br>
Evan<br>
> -----Original Message-----<br>
> From: Evan Quan <evan.quan@amd.com><br>
> Sent: Thursday, March 28, 2019 9:51 AM<br>
> To: amd-gfx@lists.freedesktop.org<br>
> Cc: Russell, Kent <Kent.Russell@amd.com>; Quan, Evan<br>
> <Evan.Quan@amd.com><br>
> Subject: [PATCH] drm/amd/powerplay: check for invalid profile mode before<br>
> switching<br>
> <br>
> Need to check for invalid profile mode settings before determining to switch<br>
> to that.<br>
> <br>
> Change-Id: Ie47cd75a73a8369c349410ea74d322df1d3d38d1<br>
> Signed-off-by: Evan Quan <evan.quan@amd.com><br>
> ---<br>
> drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 5 ++---<br>
> 1 file changed, 2 insertions(+), 3 deletions(-)<br>
> <br>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c<br>
> b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c<br>
> index 85a536924571..973a8896fa9d 100644<br>
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c<br>
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c<br>
> @@ -4906,9 +4906,6 @@ static int vega10_set_power_profile_mode(struct<br>
> pp_hwmgr *hwmgr, long *input, ui<br>
> uint8_t min_active_level;<br>
> uint32_t power_profile_mode = input[size];<br>
> <br>
> - smum_send_msg_to_smc_with_parameter(hwmgr,<br>
> PPSMC_MSG_SetWorkloadMask,<br>
> - 1 << power_profile_mode);<br>
> -<br>
> if (power_profile_mode == PP_SMC_POWER_PROFILE_CUSTOM) {<br>
> if (size == 0 || size > 4)<br>
> return -EINVAL;<br>
> @@ -4923,6 +4920,8 @@ static int vega10_set_power_profile_mode(struct<br>
> pp_hwmgr *hwmgr, long *input, ui<br>
> use_rlc_busy << 16 |<br>
> min_active_level<<24);<br>
> }<br>
> <br>
> + smum_send_msg_to_smc_with_parameter(hwmgr,<br>
> PPSMC_MSG_SetWorkloadMask,<br>
> + 1 << power_profile_mode);<br>
> hwmgr->power_profile_mode = power_profile_mode;<br>
> <br>
> return 0;<br>
> --<br>
> 2.21.0<br>
<br>
</div>
</span></font></div>
</body>
</html>