<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
How about an interface to change the timeout on a per engine (gfx, compute, dma, etc.) basis?</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<font size="2"><span style="font-size:11pt">amdgpu.lockup_timeout=<global>,<gfx>,<compute></span></font>,<sdma>,<decode>,<encode></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
if only one parameter is given, we change it globably. If more are given, we override the global one. Could also do a sysfs interface to change it on the fly.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Alex<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Michel Dänzer <michel@daenzer.net><br>
<b>Sent:</b> Friday, April 26, 2019 4:35 AM<br>
<b>To:</b> Quan, Evan; Koenig, Christian<br>
<b>Cc:</b> Xu, Feifei; Cui, Flora; amd-gfx@lists.freedesktop.org<br>
<b>Subject:</b> Re: [PATCH] drm/amdgpu: support gpu recovery tests on compute rings</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">On 2019-04-26 10:20 a.m., Quan, Evan wrote:<br>
> My concern is there is already one module parameter "lockup_timeout".<br>
> parm: lockup_timeout:GPU lockup timeout in ms > 0 (default 10000) (int)<br>
> <br>
> Adding one more "timeout" seems redundant. <br>
> And that will makes the description of "lockup_timeout"(seems working for all jobs) does not match its real effect(affect only non-compute jobs).<br>
> <br>
> A better way is to rename "lockup_timeout" to "non-compute lockup_timeout". But I do not think we can change existing module parameter. Right?<br>
<br>
Right. Also, there are already too many amdgpu module parameters, we<br>
should try to remove some rather than adding new ones for every little<br>
thing that could be tweaked. :)<br>
<br>
One possibility might be to optionally allow passing multiple values to<br>
lockup_timeout, e.g.<br>
<br>
amdgpu.lockup_timeout=10000,0<br>
<br>
The first value would need to have the same meaning as now for backwards<br>
compatibility.<br>
<br>
<br>
-- <br>
Earthling Michel Dänzer | <a href="https://www.amd.com">
https://www.amd.com</a><br>
Libre software enthusiast | Mesa and X developer<br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></div>
</span></font></div>
</body>
</html>