<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> maybe just:</div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <font size="2"><span style="font-size:11pt">amdgpu.lockup_timeout=<global>,<gfx>,<compute></span></font>,<sdma>,<video></div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> I don't think we really need separate timeouts for all the different video related engines.</div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Alex<br> </div> <div id="appendonsend"></div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Quan, Evan<br> <b>Sent:</b> Sunday, April 28, 2019 1:37 AM<br> <b>To:</b> Deucher, Alexander; Michel Dänzer; Koenig, Christian<br> <b>Cc:</b> Xu, Feifei; Cui, Flora; amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> RE: [PATCH] drm/amdgpu: support gpu recovery tests on compute rings</font> <div> </div> </div> <style>  </style> <div lang="EN-US" link="blue" vlink="purple"> <div class="x_WordSection1"> <p class="x_MsoNormal">How about <span style="color:black">amdgpu.lockup_timeout</span>=non-compute-jobs[, gfx, sdma, decode, encode][: compute-jobs] ?</p> <p class="x_MsoNormal">This will not break backward compatibility.</p> <p class="x_MsoNormal"> </p> <p class="x_MsoNormal">And I’m not sure how to map “decode” and “encode” to the uvd/vce/vcn rings. </p> <p class="x_MsoNormal">Since there are many rings related with these IPs(uvd, uvd_enc, vce, vcn_dec, vcn_enc, vcn_jpeg).</p> <p class="x_MsoNormal">Maybe we should use IP name(uvd, vce or vcn) instead of “decode/encode”?</p> <p class="x_MsoNormal"> </p> <p class="x_MsoNormal">Regards,</p> <p class="x_MsoNormal">Evan</p> <div style="border:none; border-left:solid blue 1.5pt; padding:0cm 0cm 0cm 4.0pt"> <div> <div style="border:none; border-top:solid #E1E1E1 1.0pt; padding:3.0pt 0cm 0cm 0cm"> <p class="x_MsoNormal"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> <b>On Behalf Of </b>Deucher, Alexander<br> <b>Sent:</b> 2019<span lang="ZH-CN" style="font-family:"微软雅黑",sans-serif">年</span>4<span lang="ZH-CN" style="font-family:"微软雅黑",sans-serif">月</span>26<span lang="ZH-CN" style="font-family:"微软雅黑",sans-serif">日</span> 22:24<br> <b>To:</b> Michel Dänzer <michel@daenzer.net>; Quan, Evan <Evan.Quan@amd.com>; Koenig, Christian <Christian.Koenig@amd.com><br> <b>Cc:</b> Xu, Feifei <Feifei.Xu@amd.com>; Cui, Flora <Flora.Cui@amd.com>; amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> Re: [PATCH] drm/amdgpu: support gpu recovery tests on compute rings</p> </div> </div> <p class="x_MsoNormal"> </p> <div> <p class="x_MsoNormal"><span style="font-size:12.0pt; color:black">How about an interface to change the timeout on a per engine (gfx, compute, dma, etc.) basis?</span></p> </div> <div> <p class="x_MsoNormal"><span style="color:black">amdgpu.lockup_timeout=<global>,<gfx>,<compute></span><span style="font-size:12.0pt; color:black">,<sdma>,<decode>,<encode></span><span style="font-size:12.0pt">]</span></p> </div> <div> <p class="x_MsoNormal"><span style="font-size:12.0pt; color:black">if only one parameter is given, we change it globably. If more are given, we override the global one. Could also do a sysfs interface to change it on the fly.</span></p> </div> <div> <p class="x_MsoNormal"><span style="font-size:12.0pt; color:black"> </span></p> </div> <div> <p class="x_MsoNormal"><span style="font-size:12.0pt; color:black">Alex</span></p> </div> <div class="x_MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="x_divRplyFwdMsg"> <p class="x_MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black"> amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">amd-gfx-bounces@lists.freedesktop.org</a>> on behalf of Michel Dänzer <<a href="mailto:michel@daenzer.net">michel@daenzer.net</a>><br> <b>Sent:</b> Friday, April 26, 2019 4:35 AM<br> <b>To:</b> Quan, Evan; Koenig, Christian<br> <b>Cc:</b> Xu, Feifei; Cui, Flora; <a href="mailto:amd-gfx@lists.freedesktop.org"> amd-gfx@lists.freedesktop.org</a><br> <b>Subject:</b> Re: [PATCH] drm/amdgpu: support gpu recovery tests on compute rings</span> </p> <div> <p class="x_MsoNormal"> </p> </div> </div> <div> <div> <p class="x_MsoNormal">On 2019-04-26 10:20 a.m., Quan, Evan wrote:<br> > My concern is there is already one module parameter "lockup_timeout".<br> > parm: lockup_timeout:GPU lockup timeout in ms > 0 (default 10000) (int)<br> > <br> > Adding one more "timeout" seems redundant. <br> > And that will makes the description of "lockup_timeout"(seems working for all jobs) does not match its real effect(affect only non-compute jobs).<br> > <br> > A better way is to rename "lockup_timeout" to "non-compute lockup_timeout". But I do not think we can change existing module parameter. Right?<br> <br> Right. Also, there are already too many amdgpu module parameters, we<br> should try to remove some rather than adding new ones for every little<br> thing that could be tweaked. :)<br> <br> One possibility might be to optionally allow passing multiple values to<br> lockup_timeout, e.g.<br> <br> amdgpu.lockup_timeout=10000,0<br> <br> The first value would need to have the same meaning as now for backwards<br> compatibility.<br> <br> <br> -- <br> Earthling Michel Dänzer | <a href="https://www.amd.com"> https://www.amd.com</a><br> Libre software enthusiast | Mesa and X developer<br> _______________________________________________<br> amd-gfx mailing list<br> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></p> </div> </div> </div> </div> </div> </body> </html>