<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=Windows-1252"> </head> <body text="#000000" bgcolor="#FFFFFF"> Thank you Alex and Christian for the feedback. Ori will try to add ioctl into SMI CLI to retrieve firmware versions.<br> <br> Amber<br> <br> <div class="moz-cite-prefix">On 2019-04-29 8:22 a.m., Christian König wrote:<br> </div> <blockquote type="cite" cite="mid:d6c60e91-4311-069b-0612-03337830481d@gmail.com"> <div class="moz-cite-prefix">We just need to keep in mind that sysfs has more restrictions than debugfs.<br> <br> E.g. one value per file, backward compatibility etc...<br> <br> Apart from that I don't see any reason to not do it in sysfs.<br> <br> Christian. <br> <br> Am 26.04.19 um 20:35 schrieb Russell, Kent:<br> </div> <blockquote type="cite" cite="mid:BN6PR12MB1618CE8C21ED572094D9BB10853E0@BN6PR12MB1618.namprd12.prod.outlook.com"> The main reasoning and use case for sysfs would be the SMI CLI, since unfortunately there is no ioctl support in there. <br> <br> Kent<br> <br> KENT RUSSELL<br> Sr. Software Engineer | Linux Compute Kernel<br> 1 Commerce Valley Drive East<br> Markham, ON L3T 7X6<br> O +(1) 289-695-2122 | Ext 72122<br> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> amd-gfx <a class="moz-txt-link-rfc2396E" href="mailto:amd-gfx-bounces@lists.freedesktop.org" moz-do-not-send="true"> <amd-gfx-bounces@lists.freedesktop.org></a> on behalf of Deucher, Alexander <a class="moz-txt-link-rfc2396E" href="mailto:Alexander.Deucher@amd.com" moz-do-not-send="true"> <Alexander.Deucher@amd.com></a><br> <b>Sent:</b> Friday, April 26, 2019 12:18:22 PM<br> <b>To:</b> Lin, Amber; <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org" moz-do-not-send="true"> amd-gfx@lists.freedesktop.org</a><br> <b>Cc:</b> Freehill, Chris<br> <b>Subject:</b> Re: print firmware versions on amdgpu sysfs</font> <div> </div> </div> <style type="text/css" style="display:none">  </style> <div dir="ltr"> <div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)"> We also expose the firmware versions via ioctl which is what the UMDs uses. If you'd prefer it in sysfs, we could do that too.<br> </div> <div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)"> <br> </div> <div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)"> Alex</div> <div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)"> <br> </div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> amd-gfx <a class="moz-txt-link-rfc2396E" href="mailto:amd-gfx-bounces@lists.freedesktop.org" moz-do-not-send="true"> <amd-gfx-bounces@lists.freedesktop.org></a> on behalf of Lin, Amber <a class="moz-txt-link-rfc2396E" href="mailto:Amber.Lin@amd.com" moz-do-not-send="true"> <Amber.Lin@amd.com></a><br> <b>Sent:</b> Friday, April 26, 2019 10:14 AM<br> <b>To:</b> <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org" moz-do-not-send="true"> amd-gfx@lists.freedesktop.org</a><br> <b>Cc:</b> Freehill, Chris<br> <b>Subject:</b> print firmware versions on amdgpu sysfs</font> <div> </div> </div> <div class="x_BodyFragment"><font size="2"><span style="font-size:11pt"> <div class="x_PlainText">Hi Alex,<br> <br> Currently we retrieve firmware versions from /sys/kernel/debug but this <br> requires debugfs being enabled and superuser privilege. Do you see a <br> concern we add firmware versions to amdgpu sysfs at <br> /sys/class/drm/cardX/device like vbios_version?<br> <br> Regards,<br> Amber<br> _______________________________________________<br> amd-gfx mailing list<br> <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org" moz-do-not-send="true">amd-gfx@lists.freedesktop.org</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" moz-do-not-send="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></div> </span></font></div> </div> <br> <fieldset class="mimeAttachmentHeader"></fieldset> <pre class="moz-quote-pre" wrap="">_______________________________________________ amd-gfx mailing list <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org" moz-do-not-send="true">amd-gfx@lists.freedesktop.org</a> <a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" moz-do-not-send="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></pre> </blockquote> <br> </blockquote> <br> </body> </html>