<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I reverted all the amdgpu HMM patches for 5.2 because they also depended on this patch:</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<a href="https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-5.2-wip&id=ce05ef71564f7cbe270cd4337c36ee720ea534db" id="LPlnk921619">https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-5.2-wip&id=ce05ef71564f7cbe270cd4337c36ee720ea534db</a></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
which did not have a clear line of sight for 5.2 either.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Alex<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Kuehling, Felix <Felix.Kuehling@amd.com><br>
<b>Sent:</b> Monday, May 13, 2019 3:36 PM<br>
<b>To:</b> Jerome Glisse<br>
<b>Cc:</b> linux-mm@kvack.org; airlied@gmail.com; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; alex.deucher@amd.com<br>
<b>Subject:</b> Re: [PATCH 2/2] mm/hmm: Only set FAULT_FLAG_ALLOW_RETRY for non-blocking</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">[CAUTION: External Email]<br>
<br>
Hi Jerome,<br>
<br>
Do you want me to push the patches to your branch? Or are you going to<br>
apply them yourself?<br>
<br>
Is your hmm-5.2-v3 branch going to make it into Linux 5.2? If so, do you<br>
know when? I'd like to coordinate with Dave Airlie so that we can also<br>
get that update into a drm-next branch soon.<br>
<br>
I see that Linus merged Dave's pull request for Linux 5.2, which<br>
includes the first changes in amdgpu using HMM. They're currently broken<br>
without these two patches.<br>
<br>
Thanks,<br>
Felix<br>
<br>
On 2019-05-10 4:14 p.m., Jerome Glisse wrote:<br>
> [CAUTION: External Email]<br>
><br>
> On Fri, May 10, 2019 at 07:53:24PM +0000, Kuehling, Felix wrote:<br>
>> Don't set this flag by default in hmm_vma_do_fault. It is set<br>
>> conditionally just a few lines below. Setting it unconditionally<br>
>> can lead to handle_mm_fault doing a non-blocking fault, returning<br>
>> -EBUSY and unlocking mmap_sem unexpectedly.<br>
>><br>
>> Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com><br>
> Reviewed-by: Jérôme Glisse <jglisse@redhat.com><br>
><br>
>> ---<br>
>> mm/hmm.c | 2 +-<br>
>> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
>><br>
>> diff --git a/mm/hmm.c b/mm/hmm.c<br>
>> index b65c27d5c119..3c4f1d62202f 100644<br>
>> --- a/mm/hmm.c<br>
>> +++ b/mm/hmm.c<br>
>> @@ -339,7 +339,7 @@ struct hmm_vma_walk {<br>
>> static int hmm_vma_do_fault(struct mm_walk *walk, unsigned long addr,<br>
>> bool write_fault, uint64_t *pfn)<br>
>> {<br>
>> - unsigned int flags = FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_REMOTE;<br>
>> + unsigned int flags = FAULT_FLAG_REMOTE;<br>
>> struct hmm_vma_walk *hmm_vma_walk = walk->private;<br>
>> struct hmm_range *range = hmm_vma_walk->range;<br>
>> struct vm_area_struct *vma = walk->vma;<br>
>> --<br>
>> 2.17.1<br>
>><br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br>
</div>
</span></font></div>
</body>
</html>