<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple"> <div class="WordSection1"> <p class="MsoNormal">Hi Christian ,<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">I just wonder when encounter ENOMEM error during pin amdgpu BOs can we retry validate again as below.<o:p></o:p></p> <p class="MsoNormal">With the following simply patch the Abaqus pinned issue not observed. <o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c<o:p></o:p></p> <p class="MsoNormal">index 11cbf63..72a32f5 100644<o:p></o:p></p> <p class="MsoNormal">--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c<o:p></o:p></p> <p class="MsoNormal">+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c<o:p></o:p></p> <p class="MsoNormal">@@ -902,11 +902,15 @@ int amdgpu_bo_pin_restricted(struct amdgpu_bo *bo, u32 domain,<o:p></o:p></p> <p class="MsoNormal"> bo->placements[i].lpfn = lpfn;<o:p></o:p></p> <p class="MsoNormal"> bo->placements[i].flags |= TTM_PL_FLAG_NO_EVICT;<o:p></o:p></p> <p class="MsoNormal"> }<o:p></o:p></p> <p class="MsoNormal">-<o:p></o:p></p> <p class="MsoNormal">+retry:<o:p></o:p></p> <p class="MsoNormal"> r = ttm_bo_validate(&bo->tbo, &bo->placement, &ctx);<o:p></o:p></p> <p class="MsoNormal"> if (unlikely(r)) {<o:p></o:p></p> <p class="MsoNormal">- dev_err(adev->dev, "%p pin failed\n", bo);<o:p></o:p></p> <p class="MsoNormal">- goto error;<o:p></o:p></p> <p class="MsoNormal">+ if (r == -ENOMEM){<o:p></o:p></p> <p class="MsoNormal">+ goto retry;<o:p></o:p></p> <p class="MsoNormal">+ } else {<o:p></o:p></p> <p class="MsoNormal">+ dev_err(adev->dev, "%p pin failed\n", bo);<o:p></o:p></p> <p class="MsoNormal">+ goto error;<o:p></o:p></p> <p class="MsoNormal">+ }<o:p></o:p></p> <p class="MsoNormal"> }<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal"> bo->pin_count = 1;<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">Thanks,<o:p></o:p></p> <p class="MsoNormal">Prike<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b>From:</b> Marek Olšák <maraeo@gmail.com> <br> <b>Sent:</b> Wednesday, May 15, 2019 3:33 AM<br> <b>To:</b> Christian König <ckoenig.leichtzumerken@gmail.com><br> <b>Cc:</b> Zhou, David(ChunMing) <David1.Zhou@amd.com>; Liang, Prike <Prike.Liang@amd.com>; dri-devel <dri-devel@lists.freedesktop.org>; amd-gfx mailing list <amd-gfx@lists.freedesktop.org><br> <b>Subject:</b> Re: [PATCH 11/11] drm/amdgpu: stop removing BOs from the LRU during CS<o:p></o:p></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">[CAUTION: External Email] <o:p></o:p></p> <div> <div> <div> <div> <p class="MsoNormal">This series fixes the OOM errors. However, if I torture the kernel driver more, I can get it to deadlock and end up with unkillable processes. I can also get an OOM error. I just ran the test 5 times:<o:p></o:p></p> </div> <div> <p class="MsoNormal"><o:p> </o:p></p> </div> <div> <p class="MsoNormal">AMD_DEBUG=testgdsmm glxgears & AMD_DEBUG=testgdsmm glxgears & AMD_DEBUG=testgdsmm glxgears & AMD_DEBUG=testgdsmm glxgears & AMD_DEBUG=testgdsmm glxgears<o:p></o:p></p> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <p class="MsoNormal">Marek<o:p></o:p></p> </div> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <div> <p class="MsoNormal">On Tue, May 14, 2019 at 8:31 AM Christian König <<a href="mailto:ckoenig.leichtzumerken@gmail.com">ckoenig.leichtzumerken@gmail.com</a>> wrote:<o:p></o:p></p> </div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in"> <p class="MsoNormal">This avoids OOM situations when we have lots of threads<br> submitting at the same time.<br> <br> Signed-off-by: Christian König <<a href="mailto:christian.koenig@amd.com" target="_blank">christian.koenig@amd.com</a>><br> ---<br> drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c<br> index fff558cf385b..f9240a94217b 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c<br> @@ -648,7 +648,7 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p,<br> }<br> <br> r = ttm_eu_reserve_buffers(&p->ticket, &p->validated, true,<br> - &duplicates, true);<br> + &duplicates, false);<br> if (unlikely(r != 0)) {<br> if (r != -ERESTARTSYS)<br> DRM_ERROR("ttm_eu_reserve_buffers failed.\n");<br> -- <br> 2.17.1<br> <br> _______________________________________________<br> amd-gfx mailing list<br> <a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><o:p></o:p></p> </blockquote> </div> </div> </div> </body> </html>