<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <meta name="Generator" content="Microsoft Exchange Server"> <style></style> </head> <body> <div> <div dir="auto" style="direction:ltr; margin:0; padding:0; font-family:sans-serif; font-size:11pt; color:black"> I am going to put more members which are also array after this struct, not only obj[]. Looks like this struct_size did not help on multiple array case. Thanks anyway.</div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> xiaolinkui <xiaolinkui@kylinos.cn><br> <b>Sent:</b> Friday, May 17, 2019 4:46:00 PM<br> <b>To:</b> Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); airlied@linux.ie; daniel@ffwll.ch; Pan, Xinhui; Quan, Evan<br> <b>Cc:</b> amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; xiaolinkui@kylinos.cn<br> <b>Subject:</b> [PATCH] gpu: drm: use struct_size() in kmalloc()</font> <div> </div> </div> </div> <font size="2"><span style="font-size:11pt;"> <div class="PlainText">[CAUTION: External Email]<br> <br> Use struct_size() helper to keep code simple.<br> <br> Signed-off-by: xiaolinkui <xiaolinkui@kylinos.cn><br> ---<br> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 3 +--<br> 1 file changed, 1 insertion(+), 2 deletions(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c<br> index 22bd21e..4717a64 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c<br> @@ -1375,8 +1375,7 @@ int amdgpu_ras_init(struct amdgpu_device *adev)<br> if (con)<br> return 0;<br> <br> - con = kmalloc(sizeof(struct amdgpu_ras) +<br> - sizeof(struct ras_manager) * AMDGPU_RAS_BLOCK_COUNT,<br> + con = kmalloc(struct_size(con, objs, AMDGPU_RAS_BLOCK_COUNT),<br> GFP_KERNEL|__GFP_ZERO);<br> if (!con)<br> return -ENOMEM;<br> --<br> 2.7.4<br> <br> <br> <br> </div> </span></font> </body> </html>