<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> </head> <body text="#000000" bgcolor="#FFFFFF"> <div class="moz-cite-prefix">Hi Yintian, please add this as a code comment to the patch. Christian. Am 17.05.19 um 09:17 schrieb Tao, Yintian: </div> <blockquote type="cite" cite="mid:MN2PR12MB30390AB5467D6A7080AD45C6E50B0@MN2PR12MB3039.namprd12.prod.outlook.com"> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> <style type="text/css" style="display:none;"></style> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> Hi Christian Many thanks for your review. The background is that this bo is to let psp load sos and sysdrv but under sriov, sos and sysdrv is loaded by VBIOS or hypervisor driver. The reason why not let guest driver to load it under SRIOV is that it is not safe. Best Regards Yintian Tao </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr">发件人: Koenig, Christian 发送时间: 2019年5月17日 14:53:35 收件人: Tao, Yintian 抄送: Liu, Monk; <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> 主题: Re: [PATCH] drm/amdgpu: skip fw pri bo alloc for SRIOV <div> </div> </div> <div class="BodyFragment"> <div class="PlainText">Looks good to me now, but I don't know the technical background why this BO is not needed under SRIOV. So this patch is Acked-by: Christian König <a class="moz-txt-link-rfc2396E" href="mailto:christian.koenig@amd.com"><christian.koenig@amd.com></a>. Regards, Christian. Am 17.05.19 um 04:41 schrieb Tao, Yintian: > Hi Christian > > > I have modified it according to your suggestion. Can you help review this again? Thanks in advance. > > > Best Regards > Yintian Tao > > -----Original Message----- > From: Yintian Tao <a class="moz-txt-link-rfc2396E" href="mailto:yttao@amd.com"><yttao@amd.com></a> > Sent: Thursday, May 16, 2019 7:54 PM > To: <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> > Cc: Tao, Yintian <a class="moz-txt-link-rfc2396E" href="mailto:Yintian.Tao@amd.com"><Yintian.Tao@amd.com></a>; Liu, Monk <a class="moz-txt-link-rfc2396E" href="mailto:Monk.Liu@amd.com"><Monk.Liu@amd.com></a> > Subject: [PATCH] drm/amdgpu: skip fw pri bo alloc for SRIOV > > PSP fw primary buffer is not used under SRIOV. > Therefore, we don't need to allocate memory for it. > > v2: remove superfluous check for amdgpu_bo_free_kernel(). > > Signed-off-by: Yintian Tao <a class="moz-txt-link-rfc2396E" href="mailto:yttao@amd.com"><yttao@amd.com></a> > Signed-off-by: Monk Liu <a class="moz-txt-link-rfc2396E" href="mailto:Monk.Liu@amd.com"><Monk.Liu@amd.com></a> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 17 ++++++++++------- > 1 file changed, 10 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > index c567a55..af9835c 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > @@ -905,13 +905,16 @@ static int psp_load_fw(struct amdgpu_device *adev) > if (!psp->cmd) > return -ENOMEM; > > - ret = amdgpu_bo_create_kernel(adev, PSP_1_MEG, PSP_1_MEG, > - AMDGPU_GEM_DOMAIN_GTT, > - &psp->fw_pri_bo, > - &psp->fw_pri_mc_addr, > - &psp->fw_pri_buf); > - if (ret) > - goto failed; > + /* this fw pri bo is not used under SRIOV */ > + if (!amdgpu_sriov_vf(psp->adev)) { > + ret = amdgpu_bo_create_kernel(adev, PSP_1_MEG, PSP_1_MEG, > + AMDGPU_GEM_DOMAIN_GTT, > + &psp->fw_pri_bo, > + &psp->fw_pri_mc_addr, > + &psp->fw_pri_buf); > + if (ret) > + goto failed; > + } > > ret = amdgpu_bo_create_kernel(adev, PSP_FENCE_BUFFER_SIZE, PAGE_SIZE, > AMDGPU_GEM_DOMAIN_VRAM, </div> </div> <fieldset class="mimeAttachmentHeader"></fieldset> <pre class="moz-quote-pre" wrap="">_______________________________________________ amd-gfx mailing list <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></pre> </blockquote> </body> </html>