<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body text="#000000" bgcolor="#FFFFFF"> <div class="moz-cite-prefix">On 5/27/19 3:42 AM, S, Shirish wrote: </div> <blockquote type="cite" cite="mid:1558942936-16519-1-git-send-email-shirish.s@amd.com"> <pre class="moz-quote-pre" wrap="">From: Louis Li <a class="moz-txt-link-rfc2396E" href="mailto:Ching-shih.Li@amd.com"><Ching-shih.Li@amd.com></a> [What] vce ring test fails consistently during resume in s3 cycle, due to mismatch read & write pointers. On debug/analysis its found that rptr to be compared is not being correctly updated/read, which leads to this failure. Below is the failure signature: [drm:amdgpu_vce_ring_test_ring] *ERROR* amdgpu: ring 12 test failed [drm:amdgpu_device_ip_resume_phase2] *ERROR* resume of IP block <vce_v3_0> failed -110 [drm:amdgpu_device_resume] *ERROR* amdgpu_device_ip_resume failed (-110). [How] fetch rptr appropriately, meaning move its read location further down in the code flow. With this patch applied the s3 failure is no more seen for >5k s3 cycles, which otherwise is pretty consistent. Signed-off-by: Louis Li <a class="moz-txt-link-rfc2396E" href="mailto:Ching-shih.Li@amd.com"><Ching-shih.Li@amd.com></a> --- drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c index c021b11..92f9d46 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c @@ -1084,6 +1084,8 @@ int amdgpu_vce_ring_test_ring(struct amdgpu_ring *ring) if (r) return r; + rptr = amdgpu_ring_get_rptr(ring); +</pre> </blockquote> The rptr update is there: <pre><code> uint32_t rptr = amdgpu_ring_get_rptr(ring); Are you sure this is the root cause? Regards, Leo </code></pre> <blockquote type="cite" cite="mid:1558942936-16519-1-git-send-email-shirish.s@amd.com"> <pre class="moz-quote-pre" wrap=""> amdgpu_ring_write(ring, VCE_CMD_END); amdgpu_ring_commit(ring); </pre> </blockquote> </body> </html>