<div dir="ltr">Fixed with "is".<div><br></div><div>Thanks. I'll wait for more feedback before submitting a v2.</div><div><br></div><div>Tom</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, May 30, 2019 at 11:45 AM Abramov, Slava <<a href="mailto:Slava.Abramov@amd.com">Slava.Abramov@amd.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <div dir="ltr"> <div id="gmail-m_-894554682780875538divtagdefaultwrapper" style="font-size:12pt;color:rgb(0,0,0);font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols" dir="ltr"> <p style="margin-top:0px;margin-bottom:0px">Comments inline (marked with [slava a]).</p> <p style="margin-top:0px;margin-bottom:0px"><br> </p> <p style="margin-top:0px;margin-bottom:0px">General comment - word capitalisation in the lists is inconsistent</p> <br> <br> <div style="color:rgb(0,0,0)"> <hr style="display:inline-block;width:98%"> <div id="gmail-m_-894554682780875538divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org" target="_blank">amd-gfx-bounces@lists.freedesktop.org</a>> on behalf of StDenis, Tom <<a href="mailto:Tom.StDenis@amd.com" target="_blank">Tom.StDenis@amd.com</a>><br> <b>Sent:</b> Thursday, May 30, 2019 10:56 AM<br> <b>To:</b> <a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a><br> <b>Cc:</b> StDenis, Tom<br> <b>Subject:</b> [PATCH] drm/amd/doc: add rough outline of tracepoint documentation</font> <div> </div> </div> <div class="gmail-m_-894554682780875538BodyFragment"><font size="2"><span style="font-size:11pt"> <div class="gmail-m_-894554682780875538PlainText">Signed-off-by: Tom St Denis <<a href="mailto:tom.stdenis@amd.com" target="_blank">tom.stdenis@amd.com</a>><br> ---<br> Documentation/gpu/amdgpu.rst | 10 +<br> drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 221 ++++++++++++++++++++++<br> 2 files changed, 231 insertions(+)<br> <br> diff --git a/Documentation/gpu/amdgpu.rst b/Documentation/gpu/amdgpu.rst<br> index 86138798128f..3564765110e5 100644<br> --- a/Documentation/gpu/amdgpu.rst<br> +++ b/Documentation/gpu/amdgpu.rst<br> @@ -89,6 +89,16 @@ AMDGPU RAS debugfs control interface<br> .. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c<br> :internal:<br> <br> +AMDGPU Tracing Support<br> +======================<br> +<br> +.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h<br> + :doc: AMDGPU Tracing Support<br> +<br> +<br> +.. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h<br> + :internal:<br> +<br> <br> GPU Power/Thermal Controls and Monitoring<br> =========================================<br> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h<br> index d3ca2424b5fe..71febb90d3e3 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h<br> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h<br> @@ -37,6 +37,227 @@<br> #define AMDGPU_JOB_GET_TIMELINE_NAME(job) \<br> job->base.s_fence->finished.ops->get_timeline_name(&job->base.s_fence->finished)<br> <br> +/**<br> + * DOC: AMDGPU Tracing Support<br> + *<br> + * The AMDGPU driver provides numerous trace points that can aid<br> + * in debugging. They are globally enabled by the file:<br> + *<br> + * /sys/kernel/debug/tracing/events/amdgpu/enable<br> + *<br> + * or individually by the enable files in the sub-directories<br> + * of that directory.<br> + *<br> + * amdgpu_mm_rreg, amdgpu_mm_wreg<br> + * ------------------------------<br> + *<br> + * These trace points track reads and writes to MMIO registers by</div> <div class="gmail-m_-894554682780875538PlainText"><span style="font-size:11pt">+ * the kernel driver (activity inside ring/indirect buffers are not</span><br> </div> <div class="gmail-m_-894554682780875538PlainText"><span style="font-size:11pt">+ * traced) which can be used to diagnose IP block activity and</span><br> </div> <div class="gmail-m_-894554682780875538PlainText">+ * responses.</div> <div class="gmail-m_-894554682780875538PlainText"> <div class="gmail-m_-894554682780875538PlainText" style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size:14.6667px"> <br class="gmail-m_-894554682780875538Apple-interchange-newline"> [slava a] Either 'activities are not traced' or 'activity is not traced'</div> <div class="gmail-m_-894554682780875538PlainText" style="font-family:Calibri,Helvetica,sans-serif,EmojiFont,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size:14.6667px"> <span style="font-size:11pt">[slava a] Double usage of word 'activity' sounds weird. </span></div> </div> <div class="gmail-m_-894554682780875538PlainText"><br> </div> <div class="gmail-m_-894554682780875538PlainText">[snap]</div> </span></font></div> </div> </div> </div> _______________________________________________<br> amd-gfx mailing list<br> <a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></blockquote></div>