<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Am 04.06.19 um 17:29 schrieb Tao, Yintian:<br>
</div>
<blockquote type="cite" cite="mid:MN2PR12MB3039F3AF3CA365AA420DBC79E5150@MN2PR12MB3039.namprd12.prod.outlook.com">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">Yes, you are right the error message is at wrong place.</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">May I just remove this message? <br>
</p>
</div>
</blockquote>
<br>
Fine with me, but you might want to double check who added the message and why.<br>
<br>
Something like "git blame ...." should do the trick.<br>
<br>
Christian.<br>
<br>
<blockquote type="cite" cite="mid:MN2PR12MB3039F3AF3CA365AA420DBC79E5150@MN2PR12MB3039.namprd12.prod.outlook.com">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">Best Regards</p>
<p style="margin-top:0;margin-bottom:0">Yintian Tao</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>发件人:</b> Koenig, Christian<br>
<b>发送时间:</b> 2019年6月4日 23:22:00<br>
<b>收件人:</b> Tao, Yintian; <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">
amd-gfx@lists.freedesktop.org</a><br>
<b>主题:</b> Re: 答复: [PATCH] drm/amdgpu: no need fbcon under sriov</font>
<div> </div>
</div>
<div style="background-color:#FFFFFF">
<div class="x_moz-cite-prefix">Am 04.06.19 um 17:16 schrieb Tao, Yintian:<br>
</div>
<blockquote type="cite"><style type="text/css" style="display:none">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000;
font-family:Calibri,Helvetica,sans-serif">
<p style="margin-top:0; margin-bottom:0">Hi Christian</p>
<p style="margin-top:0; margin-bottom:0"><br>
</p>
<p style="margin-top:0; margin-bottom:0">But when amdgpu driver is unloading, it will call this function.</p>
<p style="margin-top:0; margin-bottom:0"><br>
</p>
<p style="margin-top:0; margin-bottom:0">And driver unloading is an legal case under SR-IOV.</p>
<p style="margin-top:0; margin-bottom:0"><br>
</p>
<p style="margin-top:0; margin-bottom:0">Do you mean PCIe device removal indicates the unplug the real device?</p>
</div>
</blockquote>
<br>
Yes, exactly and that is not supported.<br>
<br>
Sounds like the error message is then on the wrong place.<br>
<br>
Christian.<br>
<br>
<blockquote type="cite">
<div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000;
font-family:Calibri,Helvetica,sans-serif">
<p style="margin-top:0; margin-bottom:0"><br>
</p>
<p style="margin-top:0; margin-bottom:0">Best Regards</p>
<p style="margin-top:0; margin-bottom:0">Yitnian Tao</p>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>发件人:</b> Christian König
<a class="x_moz-txt-link-rfc2396E" href="mailto:ckoenig.leichtzumerken@gmail.com" moz-do-not-send="true">
<ckoenig.leichtzumerken@gmail.com></a><br>
<b>发送时间:</b> 2019年6月4日 21:57:37<br>
<b>收件人:</b> Tao, Yintian; <a class="x_moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org" moz-do-not-send="true">
amd-gfx@lists.freedesktop.org</a><br>
<b>主题:</b> Re: [PATCH] drm/amdgpu: no need fbcon under sriov</font>
<div> </div>
</div>
<div class="x_BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="x_PlainText">Am 04.06.19 um 15:43 schrieb Yintian Tao:<br>
> Under Sriov, there is no need of the support for fbcon.<br>
<br>
NAK, that error message is not related to fbcon but means that PCIe <br>
device removal is not supported.<br>
<br>
Christian.<br>
<br>
><br>
> Signed-off-by: Yintian Tao <a class="x_moz-txt-link-rfc2396E" href="mailto:yttao@amd.com" moz-do-not-send="true">
<yttao@amd.com></a><br>
> ---<br>
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++-<br>
> 1 file changed, 2 insertions(+), 1 deletion(-)<br>
><br>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c<br>
> index 1f38d6f..28d095b 100644<br>
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c<br>
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c<br>
> @@ -1012,7 +1012,8 @@ amdgpu_pci_remove(struct pci_dev *pdev)<br>
> {<br>
> struct drm_device *dev = pci_get_drvdata(pdev);<br>
> <br>
> - DRM_ERROR("Device removal is currently not supported outside of fbcon\n");<br>
> + if (!amdgpu_sriov_vf(adev))<br>
> + DRM_ERROR("Device removal is currently not supported outside of fbcon\n");<br>
> drm_dev_unplug(dev);<br>
> drm_dev_put(dev);<br>
> pci_disable_device(pdev);<br>
<br>
</div>
</span></font></div>
</blockquote>
<br>
</div>
</blockquote>
<br>
</body>
</html>