<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Is there a bugzilla this fixes? If so, can you add a link?</div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> <br> </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> Alex<br> </div> <div id="appendonsend"></div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Francis, David <David.Francis@amd.com><br> <b>Sent:</b> Thursday, June 20, 2019 9:43 AM<br> <b>To:</b> Kazlauskas, Nicholas; amd-gfx@lists.freedesktop.org<br> <b>Cc:</b> Wentland, Harry<br> <b>Subject:</b> Re: [PATCH] Revert "drm/amd/display: Enable fast plane updates when state->allow_modeset = true"</font> <div> </div> </div> <style type="text/css" style="display:none">  </style> <div dir="ltr"> <div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif"> <p style="margin-top:0; margin-bottom:0">Reviewed-by: David Francis <david.francis@amd.com></p> <p style="margin-top:0; margin-bottom:0"><br> </p> <p style="margin-top:0; margin-bottom:0"><br> </p> </div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Nicholas Kazlauskas <nicholas.kazlauskas@amd.com><br> <b>Sent:</b> June 20, 2019 8:34:03 AM<br> <b>To:</b> amd-gfx@lists.freedesktop.org<br> <b>Cc:</b> Francis, David; Wentland, Harry; Kazlauskas, Nicholas<br> <b>Subject:</b> [PATCH] Revert "drm/amd/display: Enable fast plane updates when state->allow_modeset = true"</font> <div> </div> </div> <div class="x_BodyFragment"><font size="2"><span style="font-size:11pt"> <div class="x_PlainText">This reverts commit ebc8c6f18322ad54275997a888ca1731d74b711f.<br> <br> There are still missing corner cases with cursor interaction and these<br> fast plane updates on Picasso and Raven2 leading to endless PSTATE<br> warnings for typical desktop usage depending on the userspace.<br> <br> This change should be reverted until these issues have been resolved.<br> <br> Cc: David Francis <david.francis@amd.com><br> Cc: Harry Wentland <harry.wentland@amd.com><br> Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com><br> ---<br> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 ++++++++<br> 1 file changed, 8 insertions(+)<br> <br> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c<br> index 33dcd4187157..d6acbcfa570c 100644<br> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c<br> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c<br> @@ -6471,6 +6471,14 @@ static bool should_reset_plane(struct drm_atomic_state *state,<br> struct drm_crtc_state *new_crtc_state;<br> int i;<br> <br> + /*<br> + * TODO: Remove this hack once the checks below are sufficient<br> + * enough to determine when we need to reset all the planes on<br> + * the stream.<br> + */<br> + if (state->allow_modeset)<br> + return true;<br> +<br> /* Exit early if we know that we're adding or removing the plane. */<br> if (old_plane_state->crtc != new_plane_state->crtc)<br> return true;<br> -- <br> 2.17.1<br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></div> </span></font></div> </div> </body> </html>