<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
If both init and sw_init are empty, we don't need both.  Just rename the init callback to sw_init.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Alex<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Kim, Jonathan <Jonathan.Kim@amd.com><br>
<b>Sent:</b> Friday, June 21, 2019 5:45 AM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org<br>
<b>Cc:</b> Kim, Jonathan<br>
<b>Subject:</b> [PATCH] drm/amdgpu: add sw_init to df_v1_7</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">add df sw init to df 1.7 function to prevent regression issues on pre-vega20<br>
products.<br>
<br>
Change-Id: I4941003ea4a99ba0ea736c7ecc8800148423c379<br>
Signed-off-by: Jonathan Kim <Jonathan.Kim@amd.com><br>
---<br>
 drivers/gpu/drm/amd/amdgpu/df_v1_7.c | 5 +++++<br>
 1 file changed, 5 insertions(+)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/df_v1_7.c b/drivers/gpu/drm/amd/amdgpu/df_v1_7.c<br>
index 9935371db7ce..335f2c02878f 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/df_v1_7.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/df_v1_7.c<br>
@@ -33,6 +33,10 @@ static void df_v1_7_init (struct amdgpu_device *adev)<br>
 {<br>
 }<br>
 <br>
+static void df_v1_7_sw_init(struct amdgpu_device *adev)<br>
+{<br>
+}<br>
+<br>
 static void df_v1_7_enable_broadcast_mode(struct amdgpu_device *adev,<br>
                                           bool enable)<br>
 {<br>
@@ -111,6 +115,7 @@ static void df_v1_7_enable_ecc_force_par_wr_rmw(struct amdgpu_device *adev,<br>
 <br>
 const struct amdgpu_df_funcs df_v1_7_funcs = {<br>
         .init = df_v1_7_init,<br>
+       .sw_init = df_v1_7_sw_init,<br>
         .enable_broadcast_mode = df_v1_7_enable_broadcast_mode,<br>
         .get_fb_channel_number = df_v1_7_get_fb_channel_number,<br>
         .get_hbm_channel_number = df_v1_7_get_hbm_channel_number,<br>
-- <br>
2.17.1<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></div>
</span></font></div>
</body>
</html>