<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> <p style="margin-top:0;margin-bottom:0">Acked-by: Slava Abramov <slava.abramov@amd.com></p> </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Colin King <colin.king@canonical.com><br> <b>Sent:</b> Friday, June 28, 2019 11:05:39 AM<br> <b>To:</b> Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter; Xiao, Jack; Zhang, Hawking; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org<br> <b>Cc:</b> kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org<br> <b>Subject:</b> [PATCH][next] drm/amdgpu/mes10.1: fix duplicated assignment to adev->mes.ucode_fw_version</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">From: Colin Ian King <colin.king@canonical.com><br> <br> Currently adev->mes.ucode_fw_version is being assigned twice with<br> different values. This looks like a cut-n-paste error and instead<br> the second assignment should be adev->mes.data_fw_version. Fix<br> this.<br> <br> Addresses-Coverity: ("Unused value")<br> Fixes: 298d05460cc4 ("drm/amdgpu/mes10.1: load mes firmware file to CPU buffer")<br> Signed-off-by: Colin Ian King <colin.king@canonical.com><br> ---<br> drivers/gpu/drm/amd/amdgpu/mes_v10_1.c | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v10_1.c b/drivers/gpu/drm/amd/amdgpu/mes_v10_1.c<br> index 29fab7984855..2a27f0b30bb5 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/mes_v10_1.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/mes_v10_1.c<br> @@ -91,7 +91,7 @@ static int mes_v10_1_init_microcode(struct amdgpu_device *adev)<br> <br> mes_hdr = (const struct mes_firmware_header_v1_0 *)adev->mes.fw->data;<br> adev->mes.ucode_fw_version = le32_to_cpu(mes_hdr->mes_ucode_version);<br> - adev->mes.ucode_fw_version =<br> + adev->mes.data_fw_version =<br> le32_to_cpu(mes_hdr->mes_ucode_data_version);<br> adev->mes.uc_start_addr =<br> le32_to_cpu(mes_hdr->mes_uc_start_addr_lo) |<br> -- <br> 2.20.1<br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></div> </span></font></div> </body> </html>