<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0"><span style="font-family: Calibri, Helvetica, sans-serif, serif, EmojiFont; font-size: 16px;">Acked-by: Slava Abramov <slava.abramov@amd.com></span><br>
</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Colin King <colin.king@canonical.com><br>
<b>Sent:</b> Friday, June 28, 2019 10:24:02 AM<br>
<b>To:</b> Rex Zhu; Quan, Evan; Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org<br>
<b>Cc:</b> kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org<br>
<b>Subject:</b> [PATCH] drm/amd/powerplay: fix off-by-one array bounds check</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">From: Colin Ian King <colin.king@canonical.com><br>
<br>
The array bounds check for index is currently off-by-one and should<br>
be using >= rather than > on the upper bound. Fix this.<br>
<br>
Addresses-Coverity: ("Out-of-bounds read")<br>
Fixes: b3490673f905 ("drm/amd/powerplay: introduce the navi10 pptable implementation")<br>
Signed-off-by: Colin Ian King <colin.king@canonical.com><br>
---<br>
drivers/gpu/drm/amd/powerplay/navi10_ppt.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c<br>
index 27e5c80..f678700 100644<br>
--- a/drivers/gpu/drm/amd/powerplay/navi10_ppt.c<br>
+++ b/drivers/gpu/drm/amd/powerplay/navi10_ppt.c<br>
@@ -210,7 +210,7 @@ static int navi10_workload_map[] = {<br>
static int navi10_get_smu_msg_index(struct smu_context *smc, uint32_t index)<br>
{<br>
int val;<br>
- if (index > SMU_MSG_MAX_COUNT)<br>
+ if (index >= SMU_MSG_MAX_COUNT)<br>
return -EINVAL;<br>
<br>
val = navi10_message_map[index];<br>
-- <br>
2.7.4<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></div>
</span></font></div>
</body>
</html>