<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body> <div dir="auto"> <div><br> <div class="gmail_extra"><br> <div class="gmail_quote">Am 03.07.2019 16:00 schrieb Emil Velikov <emil.l.velikov@gmail.com>:<br type="attribution"> <blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div><font size="2"><span style="font-size:11pt"> <div>On Wed, 3 Jul 2019 at 14:48, Koenig, Christian <Christian.Koenig@amd.com> wrote:<br> ><br> > Well this is still a NAK.<br> ><br> > As stated previously please just don't remove DRM_AUTH and keep the functionality as it is.<br> ><br> AFAICT nobody was in favour of your suggestion to remove DRM_AUTH from<br> the handle to/from fd ioclts.<br> Thus this seems like the second best option.<br> </div> </span></font></div> </blockquote> </div> </div> </div> <div dir="auto"><br> </div> <div dir="auto">Well just keep it. As I said please don't change anything here.</div> <div dir="auto"><br> </div> <div dir="auto">Dropping DRM_AUTH from the driver IOCTLs was sufficient to work around the problems at hand far as I know.</div> <div dir="auto"><br> </div> <div dir="auto">And stopping those two at least prevents userspace to abuse this even more.</div> <div dir="auto"><br> </div> <div dir="auto">On the other hand I haven't seen any NAK on dropping DRM_AUTH from them.</div> <div dir="auto"><br> </div> <div dir="auto">Christian.</div> <div dir="auto"><br> </div> <div dir="auto"><br> </div> <div dir="auto"> <div class="gmail_extra"> <div class="gmail_quote"> <blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div><font size="2"><span style="font-size:11pt"> <div><br> Third route that I see is doing driver_name == "amdgpu" || driver_name<br> == "radeon" in core.<br> If you have alternative solution I'm all ears.<br> <br> -Emil<br> </div> </span></font></div> </blockquote> </div> <br> </div> </div> </div> </body> </html>