<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
auto just means do the right thing for each asic. For example, if there is a new asic program and the discovery tables are not available yet, for that program, auto means don't use the discovery table. For other programs where the table is available (e.g.,
navi10 and 14), then auto means use the table.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Alex<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Yuan, Xiaojie<br>
<b>Sent:</b> Monday, July 8, 2019 11:31 AM<br>
<b>To:</b> Alex Deucher; amd-gfx@lists.freedesktop.org<br>
<b>Cc:</b> Deucher, Alexander<br>
<b>Subject:</b> Re: [PATCH 2/2] drm/amdgpu: enable IP discovery by default on navi</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Hi Alex,<br>
<br>
I see there are many 'auto' module params for amdgpu, could you please explain about the historical intention of using value '-1'?<br>
and shall we check 'amdgpu_discovery' against '-1' for all the code paths in amdgpu_device.c and navi10_reg_init.c?<br>
<br>
BR,<br>
Xiaojie<br>
<br>
________________________________________<br>
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Alex Deucher <alexdeucher@gmail.com><br>
Sent: Wednesday, July 3, 2019 11:13 PM<br>
To: amd-gfx@lists.freedesktop.org<br>
Cc: Deucher, Alexander<br>
Subject: [PATCH 2/2] drm/amdgpu: enable IP discovery by default on navi<br>
<br>
Use the IP discovery table rather than hardcoding the<br>
settings in the driver.<br>
<br>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com><br>
---<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++-<br>
1 file changed, 2 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c<br>
index 7941a5368fb5..6f7772eeeb78 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c<br>
@@ -140,7 +140,7 @@ uint amdgpu_smu_memory_pool_size = 0;<br>
uint amdgpu_dc_feature_mask = 0;<br>
int amdgpu_async_gfx_ring = 1;<br>
int amdgpu_mcbp = 0;<br>
-int amdgpu_discovery = 0;<br>
+int amdgpu_discovery = -1;<br>
int amdgpu_mes = 0;<br>
<br>
struct amdgpu_mgpu_info mgpu_info = {<br>
@@ -592,6 +592,7 @@ module_param_named(mcbp, amdgpu_mcbp, int, 0444);<br>
/**<br>
* DOC: discovery (int)<br>
* Allow driver to discover hardware IP information from IP Discovery table at the top of VRAM.<br>
+ * (-1 = auto (default), 0 = disabled, 1 = enabled)<br>
*/<br>
MODULE_PARM_DESC(discovery,<br>
"Allow driver to discover hardware IPs from IP Discovery table at the top of VRAM");<br>
--<br>
2.20.1<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br>
</div>
</span></font></div>
</body>
</html>