<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> <p style="margin-top:0;margin-bottom:0">Reviewed-by: Kevin Wang <kevin1.wang@amd.com></p> <p style="margin-top:0;margin-bottom:0"><br> </p> <p style="margin-top:0;margin-bottom:0">Best Regards,</p> <p style="margin-top:0;margin-bottom:0">Kevin</p> </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Evan Quan <evan.quan@amd.com><br> <b>Sent:</b> Friday, July 12, 2019 10:34:46 AM<br> <b>To:</b> amd-gfx@lists.freedesktop.org<br> <b>Cc:</b> Quan, Evan<br> <b>Subject:</b> [PATCH] drm/amd/powerplay: fix memory allocation failure check</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">Fix memory allocation failure check.<br> <br> Change-Id: I012b082a7a2b92973a76db8029897fb4a3441694<br> Signed-off-by: Evan Quan <evan.quan@amd.com><br> ---<br> drivers/gpu/drm/amd/powerplay/vega20_ppt.c | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br> <br> diff --git a/drivers/gpu/drm/amd/powerplay/vega20_ppt.c b/drivers/gpu/drm/amd/powerplay/vega20_ppt.c<br> index 1fc367307ac0..9e3e737926aa 100644<br> --- a/drivers/gpu/drm/amd/powerplay/vega20_ppt.c<br> +++ b/drivers/gpu/drm/amd/powerplay/vega20_ppt.c<br> @@ -319,7 +319,7 @@ static int vega20_tables_init(struct smu_context *smu, struct smu_table *tables)<br> AMDGPU_GEM_DOMAIN_VRAM);<br> <br> smu_table->metrics_table = kzalloc(sizeof(SmuMetrics_t), GFP_KERNEL);<br> - if (smu_table->metrics_table)<br> + if (!smu_table->metrics_table)<br> return -ENOMEM;<br> smu_table->metrics_time = 0;<br> <br> -- <br> 2.21.0<br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></div> </span></font></div> </body> </html>