<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
RB,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
thanks,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Alex<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of StDenis, Tom <Tom.StDenis@amd.com><br>
<b>Sent:</b> Wednesday, July 17, 2019 8:44 AM<br>
<b>To:</b> Koenig, Christian; amd-gfx@lists.freedesktop.org<br>
<b>Subject:</b> Re: [PATCH] drm/amd/amdgpu: Fix offset for vmid selection in debugfs interface</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Thanks.<br>
<br>
<br>
Alex can I grab an R-b please?<br>
<br>
<br>
Cheers,<br>
<br>
Tom<br>
<br>
On 2019-07-16 7:30 a.m., Christian König wrote:<br>
> Am 16.07.19 um 13:24 schrieb StDenis, Tom:<br>
>> The register debugfs interface was using the wrong bitmask for vmid<br>
>> selection for GFX_CNTL.<br>
>><br>
>> Signed-off-by: Tom St Denis <tom.stdenis@amd.com><br>
><br>
> Acked-by: Christian König <christian.koenig@amd.com><br>
><br>
>> ---<br>
>> drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +-<br>
>> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
>><br>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c <br>
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c<br>
>> index 87b32873046f..59849ed9797d 100644<br>
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c<br>
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c<br>
>> @@ -132,7 +132,7 @@ static int amdgpu_debugfs_process_reg_op(bool <br>
>> read, struct file *f,<br>
>> me = (*pos & GENMASK_ULL(33, 24)) >> 24;<br>
>> pipe = (*pos & GENMASK_ULL(43, 34)) >> 34;<br>
>> queue = (*pos & GENMASK_ULL(53, 44)) >> 44;<br>
>> - vmid = (*pos & GENMASK_ULL(48, 45)) >> 54;<br>
>> + vmid = (*pos & GENMASK_ULL(58, 54)) >> 54;<br>
>> use_ring = 1;<br>
>> } else {<br>
><br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></div>
</span></font></div>
</body>
</html>