<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Acked-by: Alex Deucher <alexander.deucher@amd.com><br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Liu, Leo <Leo.Liu@amd.com><br>
<b>Sent:</b> Thursday, July 18, 2019 11:46 AM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org<br>
<b>Cc:</b> Liu, Leo<br>
<b>Subject:</b> [PATCH] drm/amdgpu/: use VCN firmware offset for cache window</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Since we are using the signed FW now, and also using PSP firmware loading,<br>
but it's still potential to break driver when loading FW directly<br>
instead of PSP, so we should add offset.<br>
<br>
Signed-off-by: Leo Liu <leo.liu@amd.com><br>
---<br>
drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 3 ---<br>
1 file changed, 3 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c<br>
index 3cb62e448a37..88e3dedcf926 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c<br>
@@ -379,11 +379,8 @@ static void vcn_v2_0_mc_resume(struct amdgpu_device *adev)<br>
WREG32_SOC15(UVD, 0, mmUVD_LMI_VCPU_CACHE_64BIT_BAR_HIGH,<br>
upper_32_bits(adev->vcn.inst->gpu_addr));<br>
offset = size;<br>
- /* No signed header for now from firmware<br>
WREG32_SOC15(UVD, 0, mmUVD_VCPU_CACHE_OFFSET0,<br>
AMDGPU_UVD_FIRMWARE_OFFSET >> 3);<br>
- */<br>
- WREG32_SOC15(UVD, 0, mmUVD_VCPU_CACHE_OFFSET0, 0);<br>
}<br>
<br>
WREG32_SOC15(UVD, 0, mmUVD_VCPU_CACHE_SIZE0, size);<br>
-- <br>
2.20.1<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></div>
</span></font></div>
</body>
</html>