<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
We need to add a /*fall through */ comment then.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Alex<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Liu, Shaoyun <Shaoyun.Liu@amd.com><br>
<b>Sent:</b> Monday, July 22, 2019 11:14 AM<br>
<b>To:</b> Gustavo A. R. Silva <gustavo@embeddedor.com>; Cox, Philip <Philip.Cox@amd.com>; Oded Gabbay <oded.gabbay@gmail.com>; Deucher, Alexander <Alexander.Deucher@amd.com>; Koenig, Christian <Christian.Koenig@amd.com>; Zhou, David(ChunMing) <David1.Zhou@amd.com>;
David Airlie <airlied@linux.ie>; Daniel Vetter <daniel@ffwll.ch><br>
<b>Cc:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org><br>
<b>Subject:</b> Re: [PATCH] drm/amdkfd/kfd_mqd_manager_v10: Fix missing break in switch statement</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">This one properly in purpose , The mqd init for CP and COMPUTE will
<br>
have the same routine .<br>
<br>
Regard<br>
<br>
sshaoyun.liu<br>
<br>
On 2019-07-21 6:59 p.m., Gustavo A. R. Silva wrote:<br>
> Add missing break statement in order to prevent the code from falling<br>
> through to case KFD_MQD_TYPE_COMPUTE.<br>
><br>
> This bug was found thanks to the ongoing efforts to enable<br>
> -Wimplicit-fallthrough.<br>
><br>
> Fixes: 14328aa58ce5 ("drm/amdkfd: Add navi10 support to amdkfd. (v3)")<br>
> Cc: stable@vger.kernel.org<br>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com><br>
> ---<br>
> drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c | 1 +<br>
> 1 file changed, 1 insertion(+)<br>
><br>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c b/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c<br>
> index 4f8a6ffc5775..1d8b13ad46f9 100644<br>
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c<br>
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_v10.c<br>
> @@ -430,6 +430,7 @@ struct mqd_manager *mqd_manager_init_v10(enum KFD_MQD_TYPE type,<br>
> switch (type) {<br>
> case KFD_MQD_TYPE_CP:<br>
> pr_debug("%s@%i\n", __func__, __LINE__);<br>
> + break;<br>
> case KFD_MQD_TYPE_COMPUTE:<br>
> pr_debug("%s@%i\n", __func__, __LINE__);<br>
> mqd->allocate_mqd = allocate_mqd;<br>
</div>
</span></font></div>
</body>
</html>