<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple"> <div class="WordSection1"> <p class="MsoNormal"><span style="color:#1F497D">I think that’s ok to put in sw_init.<o:p></o:p></span></p> <p class="MsoPlainText">Reviewed-by: Kenneth Feng <<a href="mailto:kenneth.feng@amd.com">kenneth.feng@amd.com</a>><o:p></o:p></p> <p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p> <p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b>From:</b> amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] <b>On Behalf Of </b>Quan, Evan<br> <b>Sent:</b> Friday, July 26, 2019 9:04 AM<br> <b>To:</b> Wang, Kevin(Yang) <Kevin1.Wang@amd.com>; amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> RE: [PATCH 2/2] drm/amd/powerplay: enable SW SMU reset functionality<o:p></o:p></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Times New Roman",serif">[CAUTION: External Email] <o:p></o:p></span></p> <div> <p class="MsoNormal">It’s a bug fix for uploading new pptable from sysfs.<o:p></o:p></p> <p class="MsoNormal">And it’s not hardware involved. The real hardware operation involved with this is in smu_v11_0_enable_thermal_alert.<o:p></o:p></p> <p class="MsoNormal">And in old powerplay routine, this is also put in sw_init and we do not find any problem with that until now.<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">Regards,<o:p></o:p></p> <p class="MsoNormal">Evan<o:p></o:p></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b>From:</b> Wang, Kevin(Yang) <<a href="mailto:Kevin1.Wang@amd.com">Kevin1.Wang@amd.com</a>> <br> <b>Sent:</b> Thursday, July 25, 2019 9:08 PM<br> <b>To:</b> Quan, Evan <<a href="mailto:Evan.Quan@amd.com">Evan.Quan@amd.com</a>>; <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br> <b>Subject:</b> Re: [PATCH 2/2] drm/amd/powerplay: enable SW SMU reset functionality<o:p></o:p></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <div id="appendonsend"> <p class="MsoNormal"><span style="font-size:12.0pt;color:black">I don't recommend that, because obviously this is a <b>hardware</b> <b>operation</b>, so why need to move it into <b>sw</b> <b>init</b>?<o:p></o:p></span></p> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black">Is this a workaround solution, or is it specific to which asic?<o:p></o:p></span></p> </div> </div> <div id="appendonsend"> <p class="MsoNormal"><span style="font-size:12.0pt;color:black">and set pptable from sysfs and do baco reset operation need to call these functions, have you test it?<o:p></o:p></span></p> </div> <div id="appendonsend"> <p class="MsoNormal"><span style="font-size:12.0pt;color:black">the function in amdgpu_smu.c and smu_v11_0.c need work correctly in all asic,<o:p></o:p></span></p> </div> <div id="appendonsend"> <p class="MsoNormal"><span style="font-size:12.0pt;color:black">it needs to be done carefully, unless there is a good reason.<o:p></o:p></span></p> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p> </div> </div> <div id="appendonsend"> <p class="MsoNormal"><span style="font-size:12.0pt;color:black">Best Regards,<br> Kevin<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black"><o:p> </o:p></span></p> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="divRplyFwdMsg"> <p class="MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black"> amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">amd-gfx-bounces@lists.freedesktop.org</a>> on behalf of Evan Quan <<a href="mailto:evan.quan@amd.com">evan.quan@amd.com</a>><br> <b>Sent:</b> Thursday, July 25, 2019 10:39 AM<br> <b>To:</b> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>><br> <b>Cc:</b> Quan, Evan <<a href="mailto:Evan.Quan@amd.com">Evan.Quan@amd.com</a>><br> <b>Subject:</b> [PATCH 2/2] drm/amd/powerplay: enable SW SMU reset functionality</span> <o:p></o:p></p> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal">Move SMU irq handler register to sw_init as that's totally<br> software related. Otherwise, it will prevent SMU reset working.<br> <br> Change-Id: Ibd3e48ae9a90ab57f42b3f2ddbb736deeebc8715<br> Signed-off-by: Evan Quan <<a href="mailto:evan.quan@amd.com">evan.quan@amd.com</a>><br> ---<br> drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 16 +++++++++-------<br> 1 file changed, 9 insertions(+), 7 deletions(-)<br> <br> diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c<br> index 6935a00cd389..a5079b93caa3 100644<br> --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c<br> +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c<br> @@ -741,6 +741,12 @@ static int smu_sw_init(void *handle)<br> return ret;<br> }<br> <br> + ret = smu_register_irq_handler(smu);<br> + if (ret) {<br> + pr_err("Failed to register smc irq handler!\n");<br> + return ret;<br> + }<br> +<br> return 0;<br> }<br> <br> @@ -750,6 +756,9 @@ static int smu_sw_fini(void *handle)<br> struct smu_context *smu = &adev->smu;<br> int ret;<br> <br> + kfree(smu->irq_source);<br> + smu->irq_source = NULL;<br> +<br> ret = smu_smc_table_sw_fini(smu);<br> if (ret) {<br> pr_err("Failed to sw fini smc table!\n");<br> @@ -1061,10 +1070,6 @@ static int smu_hw_init(void *handle)<br> if (ret)<br> goto failed;<br> <br> - ret = smu_register_irq_handler(smu);<br> - if (ret)<br> - goto failed;<br> -<br> if (!smu->pm_enabled)<br> adev->pm.dpm_enabled = false;<br> else<br> @@ -1094,9 +1099,6 @@ static int smu_hw_fini(void *handle)<br> kfree(table_context->overdrive_table);<br> table_context->overdrive_table = NULL;<br> <br> - kfree(smu->irq_source);<br> - smu->irq_source = NULL;<br> -<br> ret = smu_fini_fb_allocations(smu);<br> if (ret)<br> return ret;<br> -- <br> 2.22.0<br> <br> _______________________________________________<br> amd-gfx mailing list<br> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><o:p></o:p></p> </div> </div> </div> </div> </div> </body> </html>