<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div id="appendonsend" style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Alex Deucher <alexdeucher@gmail.com><br>
<b>Sent:</b> Monday, August 19, 2019 11:33 PM<br>
<b>To:</b> Wang, Kevin(Yang) <Kevin1.Wang@amd.com><br>
<b>Cc:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; Feng, Kenneth <Kenneth.Feng@amd.com>; Quan, Evan <Evan.Quan@amd.com>; Huang, Ray <Ray.Huang@amd.com><br>
<b>Subject:</b> Re: [PATCH] drm/amd/powerplay: add smu_smc_read_sensor support for arcturus</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText">On Fri, Aug 16, 2019 at 3:22 AM Wang, Kevin(Yang) <Kevin1.Wang@amd.com> wrote:<br>
><br>
> the bellow patch refine the sensor read sequence,<br>
> but missed to add arcuturs support. (arcuturs_ppt.c)<br>
><br>
> drm/amd/powerplay: change smu_read_sensor sequence in smu<br>
><br>
> Signed-off-by: Kevin Wang <kevin1.wang@amd.com><br>
> ---<br>
> drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 5 ++++-<br>
> 1 file changed, 4 insertions(+), 1 deletion(-)<br>
><br>
> diff --git a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c<br>
> index fcf623cf5d2c..850b2a1ef329 100644<br>
> --- a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c<br>
> +++ b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c<br>
> @@ -1012,6 +1012,9 @@ static int arcturus_read_sensor(struct smu_context *smu,<br>
> PPTable_t *pptable = table_context->driver_pptable;<br>
> int ret = 0;<br>
><br>
> + if(!data || !size)<br>
<br>
Please add a space between if the if and the (. E.g.,<br>
if (!data || !size)<br>
<br>
Alex</div>
<div class="PlainText"><br>
</div>
<div class="PlainText">[kevin]:</div>
<div class="PlainText">thanks, i will correct it.<br>
<br>
> + return -EINVAL;<br>
> +<br>
> switch (sensor) {<br>
> case AMDGPU_PP_SENSOR_MAX_FAN_RPM:<br>
> *(uint32_t *)data = pptable->FanMaximumRpm;<br>
> @@ -1036,7 +1039,7 @@ static int arcturus_read_sensor(struct smu_context *smu,<br>
> *size = 4;<br>
> break;<br>
> default:<br>
> - return -EINVAL;<br>
> + ret = smu_smc_read_sensor(smu, sensor, data, size);<br>
> }<br>
><br>
> return ret;<br>
> --<br>
> 2.22.0<br>
><br>
> _______________________________________________<br>
> amd-gfx mailing list<br>
> amd-gfx@lists.freedesktop.org<br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br>
</div>
</span></font></div>
</body>
</html>