<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
</div>
<div id="appendonsend"></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Ville Syrjälä <ville.syrjala@linux.intel.com><br>
<b>Sent:</b> Saturday, August 24, 2019 02:41<br>
<b>To:</b> Lin, Wayne <Wayne.Lin@amd.com><br>
<b>Cc:</b> dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>; Li, Sun peng (Leo) <Sunpeng.Li@amd.com>; Kazlauskas, Nicholas <Nicholas.Kazlauskas@amd.com><br>
<b>Subject:</b> Re: [PATCH] drm/drm_connector: add additional aspect ratio values</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="PlainText">On Thu, Aug 22, 2019 at 05:50:02PM -0400, Wayne Lin wrote:<br>
> For HDMI2.0 CTS item - HF1-35, it verifies if the source generates<br>
> video timing "64:27" video format correctly.<br>
> <br>
> eg: (vic-76) 1920x1080p@60Hz,24bpp<br>
> <br>
> This patch add on "64:27" and "256:135" to drm_aspect_ratio_enum_list.<br>
> Thereafter, one can specify the aspect ratio to "64:27" or "256:135"<br>
> after creating aspect ratio property.<br>
> <br>
> Change-Id: Ifc9df54e8e8f78e70960fcd737a3a57e49c81152<br>
> Signed-off-by: Wayne Lin <waynelin@amd.com><br>
> ---<br>
> drivers/gpu/drm/drm_connector.c | 2 ++<br>
> 1 file changed, 2 insertions(+)<br>
> <br>
> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c<br>
> index 3a0cacb71235..c0629a01d08e 100644<br>
> --- a/drivers/gpu/drm/drm_connector.c<br>
> +++ b/drivers/gpu/drm/drm_connector.c<br>
> @@ -772,6 +772,8 @@ static const struct drm_prop_enum_list drm_aspect_ratio_enum_list[] = {<br>
> { DRM_MODE_PICTURE_ASPECT_NONE, "Automatic" },<br>
> { DRM_MODE_PICTURE_ASPECT_4_3, "4:3" },<br>
> { DRM_MODE_PICTURE_ASPECT_16_9, "16:9" },<br>
> + { DRM_MODE_PICTURE_ASPECT_64_27, "64:27" },<br>
> + { DRM_MODE_PICTURE_ASPECT_256_135, "256:135" },<br>
<br>
> Not 100% sure we want to expose these via the property because the<br>
> infoframe can't convey these independently from the VIC.</div>
<div class="PlainText"><br>
</div>
<div class="PlainText">Agree with that it can't be independent from the VIC. </div>
<div class="PlainText">When building up hdmi avi infoframe by using "drm_hdmi_avi_infoframe_from_display_mode" in drm_edid, </div>
<div class="PlainText">it will refer to the VIC to set up the aspect ratio if the aspect ratio is not specified in mode.</div>
<div class="PlainText">However, if the aspect ratio is specified to a value other than none, current logic of code will use the specified value. </div>
<div class="PlainText"><br>
</div>
<div class="PlainText">The main reason of this patch is for capable indicating the exact VIC wanted. </div>
<div class="PlainText">There are some modes defined in CTA-861 with same timing but different aspect ratio.</div>
<div class="PlainText">eg: VIC 103 & VIC 93</div>
<div class="PlainText">Without these new definitions, we cannot distinguish these different modes and might set a wrong VIC in AVI infoframe.</div>
<div class="PlainText"><br>
</div>
<div class="PlainText">> };<br>
> <br>
> static const struct drm_prop_enum_list drm_content_type_enum_list[] = {<br>
> -- <br>
> 2.17.1<br>
> <br>
> _______________________________________________<br>
> dri-devel mailing list<br>
> dri-devel@lists.freedesktop.org<br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/dri-devel">https://lists.freedesktop.org/mailman/listinfo/dri-devel</a><br>
<br>
-- <br>
Ville Syrjälä<br>
Intel<br>
</div>
</span></font></div>
</body>
</html>