<div dir="auto"><div>Hi Andrey, spotted a typo below, also typo in the title s/EERPOM/EEPROM/</div><div dir="auto"><br></div><div dir="auto">Regards</div><div dir="auto">Nils<br><br><div class="gmail_quote" dir="auto"><div dir="ltr" class="gmail_attr">Den fre 6 sep. 2019 17:13Andrey Grodzovsky <<a href="mailto:andrey.grodzovsky@amd.com">andrey.grodzovsky@amd.com</a>> skrev:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The table grows quickly during debug/development effort when<br>
multiple RAS errors are injected. Allow to avoid this by setting<br>
table header back to empty if needed.<br>
<br>
Signed-off-by: Andrey Grodzovsky <<a href="mailto:andrey.grodzovsky@amd.com" target="_blank" rel="noreferrer">andrey.grodzovsky@amd.com</a>><br>
---<br>
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 8 ++++++++<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 3 ++-<br>
3 files changed, 11 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h<br>
index 0d11aa8..405c55a 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h<br>
@@ -169,6 +169,7 @@ extern int amdgpu_discovery;<br>
extern int amdgpu_mes;<br>
extern int amdgpu_noretry;<br>
extern int amdgpu_force_asic_type;<br>
+extern int amdgpu_ras_eeprom_reset;<br>
<br>
#ifdef CONFIG_DRM_AMDGPU_SI<br>
extern int amdgpu_si_support;<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c<br>
index 5a7f929..6e101a5 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c<br>
@@ -145,6 +145,7 @@ int amdgpu_discovery = -1;<br>
int amdgpu_mes = 0;<br>
int amdgpu_noretry = 1;<br>
int amdgpu_force_asic_type = -1;<br>
+int amdgpu_ras_eeprom_reset = -1;<br>
<br>
struct amdgpu_mgpu_info mgpu_info = {<br>
.mutex = __MUTEX_INITIALIZER(mgpu_info.mutex),<br>
@@ -530,6 +531,13 @@ MODULE_PARM_DESC(ras_mask, "Mask of RAS features to enable (default 0xffffffff),<br>
module_param_named(ras_mask, amdgpu_ras_mask, uint, 0444);<br>
<br>
/**<br>
+ * DOC: ras_eeprom_reset (int)<br>
+ * Reset EEPROM table to zerro entries.<br>
+ */<br>
+MODULE_PARM_DESC(ras_eeprom_reset, "Reset RAS EEPROM table to zerro entries (1 = reset, -1 = auto (default - don't reset)");<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">s/zerro/zero/ in two places</div><div dir="auto"><br></div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+module_param_named(ras_eeprom_reset, amdgpu_ras_eeprom_reset, int, 0444);<br>
+<br>
+/**<br>
* DOC: si_support (int)<br>
* Set SI support driver. This parameter works after set config CONFIG_DRM_AMDGPU_SI. For SI asic, when radeon driver is enabled,<br>
* set value 0 to use radeon driver, while set value 1 to use amdgpu driver. The default is using radeon driver when it available,<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c<br>
index 43dd4ab..75c6fc0 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c<br>
@@ -140,7 +140,8 @@ int amdgpu_ras_eeprom_init(struct amdgpu_ras_eeprom_control *control)<br>
<br>
__decode_table_header_from_buff(hdr, &buff[2]);<br>
<br>
- if (hdr->header == EEPROM_TABLE_HDR_VAL) {<br>
+ if (amdgpu_ras_eeprom_reset != 1 &&<br>
+ hdr->header == EEPROM_TABLE_HDR_VAL) {<br>
control->num_recs = (hdr->tbl_size - EEPROM_TABLE_HEADER_SIZE) /<br>
EEPROM_TABLE_RECORD_SIZE;<br>
DRM_DEBUG_DRIVER("Found existing EEPROM table with %d records",<br>
-- <br>
2.7.4<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
<a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank" rel="noreferrer">amd-gfx@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" rel="noreferrer noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></blockquote></div></div></div>