<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Series is:</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Reviewed-by: Alex Deucher <alexander.deucher@amd.com><br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Zhao, Yong <Yong.Zhao@amd.com><br>
<b>Sent:</b> Monday, September 23, 2019 12:30 AM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Zhao, Yong <Yong.Zhao@amd.com><br>
<b>Subject:</b> [PATCH 3/3] drm/amdkfd: Remove unnecessary pm_init() for non HWS mode</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">The packet manager is not needed for non HWS mode except Hawaii, so only<br>
initialize it for Hawaii under non HWS mode. This will simplify debugging<br>
under non HWS mode for all new asics, because it eliminates one variable<br>
out of the equation in non HWS mode<br>
<br>
Change-Id: Ie2b61b546299a50366b9ab97900f4bb13de33d5b<br>
Signed-off-by: Yong Zhao <Yong.Zhao@amd.com><br>
---<br>
drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 10 ++++++++--<br>
1 file changed, 8 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c<br>
index c47b88987c87..c826634938d2 100644<br>
--- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c<br>
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c<br>
@@ -902,12 +902,18 @@ static void uninitialize(struct device_queue_manager *dqm)<br>
static int start_nocpsch(struct device_queue_manager *dqm)<br>
{<br>
init_interrupts(dqm);<br>
- return pm_init(&dqm->packets, dqm);<br>
+ <br>
+ if (dqm->dev->device_info->asic_family == CHIP_HAWAII)<br>
+ return pm_init(&dqm->packets, dqm);<br>
+ <br>
+ return 0;<br>
}<br>
<br>
static int stop_nocpsch(struct device_queue_manager *dqm)<br>
{<br>
- pm_uninit(&dqm->packets);<br>
+ if (dqm->dev->device_info->asic_family == CHIP_HAWAII)<br>
+ pm_uninit(&dqm->packets);<br>
+ <br>
return 0;<br>
}<br>
<br>
-- <br>
2.17.1<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></div>
</span></font></div>
</body>
</html>