<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@DengXian";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> Wang, Kevin(Yang) <Kevin1.Wang@amd.com> <br>
<b>Sent:</b> Monday, September 23, 2019 5:25 PM<br>
<b>To:</b> Liang, Prike <Prike.Liang@amd.com>; amd-gfx@lists.freedesktop.org<br>
<b>Cc:</b> arron.liu@amd.com; Huang, Ray <Ray.Huang@amd.com>; Quan, Evan <Evan.Quan@amd.com>; Feng, Kenneth <Kenneth.Feng@amd.com><br>
<b>Subject:</b> Re: [PATCH 2/5] drm/amd/powerplay: add interface for forcing and unforcing dpm limit value<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal"><span style="font-size:12.0pt;color:black">comment inline.<o:p></o:p></span></p>
</div>
<div class="MsoNormal" align="center" style="text-align:center">
<hr size="2" width="98%" align="center">
</div>
<div id="divRplyFwdMsg">
<p class="MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black"> amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">amd-gfx-bounces@lists.freedesktop.org</a>> on behalf of Liang, Prike <<a href="mailto:Prike.Liang@amd.com">Prike.Liang@amd.com</a>><br>
<b>Sent:</b> Monday, September 23, 2019 4:43 PM<br>
<b>To:</b> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>><br>
<b>Cc:</b> <a href="mailto:arron.liu@amd.com">arron.liu@amd.com</a> <<a href="mailto:arron.liu@amd.com">arron.liu@amd.com</a>>; Huang, Ray <<a href="mailto:Ray.Huang@amd.com">Ray.Huang@amd.com</a>>; Liang, Prike <<a href="mailto:Prike.Liang@amd.com">Prike.Liang@amd.com</a>>;
Quan, Evan <<a href="mailto:Evan.Quan@amd.com">Evan.Quan@amd.com</a>>; Feng, Kenneth <<a href="mailto:Kenneth.Feng@amd.com">Kenneth.Feng@amd.com</a>><br>
<b>Subject:</b> [PATCH 2/5] drm/amd/powerplay: add interface for forcing and unforcing dpm limit value</span>
<o:p></o:p></p>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal">That's base function for forcing and unforcing dpm limit value.<br>
<br>
Signed-off-by: Prike Liang <<a href="mailto:Prike.Liang@amd.com">Prike.Liang@amd.com</a>><br>
---<br>
drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 62 ++++++++++++++++++++++++++++++<br>
1 file changed, 62 insertions(+)<br>
<br>
diff --git a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c<br>
index 9311b6a..4bb7e1c 100644<br>
--- a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c<br>
+++ b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c<br>
@@ -304,6 +304,66 @@ static int renoir_dpm_set_uvd_enable(struct smu_context *smu, bool enable)<br>
return ret;<br>
}<br>
<br>
+static int renoir_force_dpm_limit_value(struct smu_context *smu, bool highest)<br>
+{<br>
+ int ret = 0, i = 0;<br>
+ uint32_t min_freq, max_freq, force_freq;<br>
+ enum smu_clk_type clk_type;<br>
+<br>
+ enum smu_clk_type clks[] = {<br>
+ SMU_GFXCLK,<br>
+ SMU_MCLK,<br>
+ SMU_SOCCLK,<br>
+ };<br>
+<br>
+ for (i = 0; i < ARRAY_SIZE(clks); i++) {<br>
+ clk_type = clks[i];<br>
+ ret = smu_get_dpm_freq_range(smu, clk_type, &min_freq, &max_freq);<br>
+ if (ret)<br>
+ return ret;<br>
+<br>
+ force_freq = highest ? max_freq : min_freq;<br>
+ ret = smu_set_soft_freq_range(smu, clk_type, force_freq, force_freq);<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">[kevin]:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">this api is depend on message "SetSoftMaxByFreq" and "SetSoftMinByFreq".<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">the apu has this message? and have you verify it?<o:p></o:p></p>
<p class="MsoNormal">[Prike]:<o:p></o:p></p>
<p class="MsoNormal">Seems APU hasn’t export the message and need send the related clock such as PPSMC_MSG_SetSoftMaxGfxClk<o:p></o:p></p>
<p class="MsoNormal">for this case.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">+ if (ret)<br>
+ return ret;<br>
+ }<br>
+<br>
+ return ret;<br>
+}<br>
+<br>
+static int renoir_unforce_dpm_levels(struct smu_context *smu) {<br>
+<br>
+ int ret = 0, i = 0;<br>
+ uint32_t min_freq, max_freq;<br>
+ enum smu_clk_type clk_type;<br>
+<br>
+ struct clk_feature_map {<br>
+ enum smu_clk_type clk_type;<br>
+ uint32_t feature;<br>
+ } clk_feature_map[] = {<br>
+ {SMU_GFXCLK, SMU_FEATURE_DPM_GFXCLK_BIT},<br>
+ {SMU_MCLK, SMU_FEATURE_DPM_UCLK_BIT},<br>
+ {SMU_SOCCLK, SMU_FEATURE_DPM_SOCCLK_BIT},<br>
+ };<br>
+<br>
+ for (i = 0; i < ARRAY_SIZE(clk_feature_map); i++) {<br>
+ if (!smu_feature_is_enabled(smu, clk_feature_map[i].feature))<br>
+ continue;<br>
+<br>
+ clk_type = clk_feature_map[i].clk_type;<br>
+<br>
+ ret = smu_get_dpm_freq_range(smu, clk_type, &min_freq, &max_freq);<br>
+ if (ret)<br>
+ return ret;<br>
+<br>
+ ret = smu_set_soft_freq_range(smu, clk_type, min_freq, max_freq);<br>
+ if (ret)<br>
+ return ret;<br>
+ }<br>
+<br>
+ return ret;<br>
+}<br>
+<br>
static const struct pptable_funcs renoir_ppt_funcs = {<br>
.get_smu_msg_index = renoir_get_smu_msg_index,<br>
.get_smu_table_index = renoir_get_smu_table_index,<br>
@@ -313,6 +373,8 @@ static const struct pptable_funcs renoir_ppt_funcs = {<br>
.print_clk_levels = renoir_print_clk_levels,<br>
.get_current_power_state = renoir_get_current_power_state,<br>
.dpm_set_uvd_enable = renoir_dpm_set_uvd_enable,<br>
+ .force_dpm_limit_value = renoir_force_dpm_limit_value,<br>
+ .unforce_dpm_levels = renoir_unforce_dpm_levels,<br>
};<br>
<br>
void renoir_set_ppt_funcs(struct smu_context *smu)<br>
-- <br>
2.7.4<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><o:p></o:p></p>
</div>
</div>
</div>
</div>
</body>
</html>