<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple"> <div class="WordSection1"> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal"><o:p> </o:p></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b>From:</b> Wang, Kevin(Yang) <Kevin1.Wang@amd.com> <br> <b>Sent:</b> Monday, September 23, 2019 5:29 PM<br> <b>To:</b> Liang, Prike <Prike.Liang@amd.com>; amd-gfx@lists.freedesktop.org<br> <b>Cc:</b> arron.liu@amd.com; Huang, Ray <Ray.Huang@amd.com>; Quan, Evan <Evan.Quan@amd.com>; Feng, Kenneth <Kenneth.Feng@amd.com><br> <b>Subject:</b> Re: [PATCH 4/5] drm/amd/powerplay: add the interfaces for getting and setting profiling dpm clock level<o:p></o:p></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <p class="MsoNormal"><span style="font-size:12.0pt;color:black">comment inline.<o:p></o:p></span></p> </div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="divRplyFwdMsg"> <p class="MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black"> amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">amd-gfx-bounces@lists.freedesktop.org</a>> on behalf of Liang, Prike <<a href="mailto:Prike.Liang@amd.com">Prike.Liang@amd.com</a>><br> <b>Sent:</b> Monday, September 23, 2019 4:43 PM<br> <b>To:</b> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>><br> <b>Cc:</b> <a href="mailto:arron.liu@amd.com">arron.liu@amd.com</a> <<a href="mailto:arron.liu@amd.com">arron.liu@amd.com</a>>; Huang, Ray <<a href="mailto:Ray.Huang@amd.com">Ray.Huang@amd.com</a>>; Liang, Prike <<a href="mailto:Prike.Liang@amd.com">Prike.Liang@amd.com</a>>; Quan, Evan <<a href="mailto:Evan.Quan@amd.com">Evan.Quan@amd.com</a>>; Feng, Kenneth <<a href="mailto:Kenneth.Feng@amd.com">Kenneth.Feng@amd.com</a>><br> <b>Subject:</b> [PATCH 4/5] drm/amd/powerplay: add the interfaces for getting and setting profiling dpm clock level</span> <o:p></o:p></p> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> </div> <div> <div> <p class="MsoNormal">implement get_profiling_clk_mask and force_clk_levels for forcing dpm clk to limit value.<br> <br> Signed-off-by: Prike Liang <<a href="mailto:Prike.Liang@amd.com">Prike.Liang@amd.com</a>><br> ---<br> drivers/gpu/drm/amd/powerplay/renoir_ppt.c | 83 ++++++++++++++++++++++++++++++<br> 1 file changed, 83 insertions(+)<br> <br> diff --git a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c<br> index f87aa56..c6aae1c 100644<br> --- a/drivers/gpu/drm/amd/powerplay/renoir_ppt.c<br> +++ b/drivers/gpu/drm/amd/powerplay/renoir_ppt.c<br> @@ -392,6 +392,87 @@ static int renoir_get_workload_type(struct smu_context *smu, uint32_t profile)<br> return pplib_workload;<br> }<br> <br> +static int renoir_get_profiling_clk_mask(struct smu_context *smu,<br> + enum amd_dpm_forced_level level,<br> + uint32_t *sclk_mask,<br> + uint32_t *mclk_mask,<br> + uint32_t *soc_mask)<br> +{<br> +<br> + if (level == AMD_DPM_FORCED_LEVEL_PROFILE_MIN_SCLK) {<br> + if (sclk_mask)<br> + *sclk_mask = 0;<br> + } else if (level == AMD_DPM_FORCED_LEVEL_PROFILE_MIN_MCLK) {<br> + if (mclk_mask)<br> + *mclk_mask = 0;<br> + } else if (level == AMD_DPM_FORCED_LEVEL_PROFILE_PEAK) {<br> + if(sclk_mask)<br> + /* The sclk as gfxclk and has three level about max/min/current */<br> + *sclk_mask = 3 - 1;<o:p></o:p></p> </div> <div> <p class="MsoNormal">[kevin]:<o:p></o:p></p> </div> <div> <p class="MsoNormal">you should return the max level not current level.<o:p></o:p></p> <p class="MsoNormal"><b><i>[Prike] Yeah, the clause will return max dpm level index.</i></b><o:p></o:p></p> </div> <div> <p class="MsoNormal">+<br> + if(mclk_mask)<br> + *mclk_mask = NUM_MEMCLK_DPM_LEVELS - 1;<br> +<br> + if(soc_mask)<br> + *soc_mask = NUM_SOCCLK_DPM_LEVELS - 1;<br> + }<br> +<br> + return 0;<br> +}<br> +<br> +static int renoir_force_clk_levels(struct smu_context *smu,<br> + enum smu_clk_type clk_type, uint32_t mask)<br> +{<br> +<br> + int ret = 0 ;<br> + uint32_t soft_min_level = 0, soft_max_level = 0, min_freq = 0, max_freq = 0;<br> + DpmClocks_t *clk_table = smu->smu_table.clocks_table;<br> +<br> + soft_min_level = mask ? (ffs(mask) - 1) : 0;<br> + soft_max_level = mask ? (fls(mask) - 1) : 0;<br> +<br> + switch (clk_type) {<br> + case SMU_GFXCLK:<br> + case SMU_SCLK:<br> + ret = smu_get_dpm_freq_range(smu, SMU_GFXCLK, &min_freq, &max_freq);<br> + if (ret)<br> + return ret;<br> + ret = smu_send_smc_msg_with_param(smu, SMU_MSG_SetSoftMaxGfxClk, max_freq);<br> + if (ret)<br> + return ret;<br> + ret = smu_send_smc_msg_with_param(smu, SMU_MSG_SetHardMinGfxClk, min_freq);<br> + if (ret)<br> + return ret;<br> + break;<br> + case SMU_SOCCLK:<br> + GET_DPM_CUR_FREQ(clk_table, clk_type, soft_min_level, min_freq);<br> + GET_DPM_CUR_FREQ(clk_table, clk_type, soft_max_level, max_freq);<br> + ret = smu_send_smc_msg_with_param(smu, SMU_MSG_SetSoftMaxSocclkByFreq, max_freq);<br> + if (ret)<br> + return ret;<br> + ret = smu_send_smc_msg_with_param(smu, SMU_MSG_SetHardMinSocclkByFreq, min_freq);<br> + if (ret)<br> + return ret;<br> + break;<br> + case SMU_MCLK:<br> + case SMU_FCLK:<br> + GET_DPM_CUR_FREQ(clk_table, clk_type, soft_min_level, min_freq);<br> + GET_DPM_CUR_FREQ(clk_table, clk_type, soft_max_level, max_freq);<br> + ret = smu_send_smc_msg_with_param(smu, SMU_MSG_SetSoftMaxFclkByFreq, max_freq);<br> + if (ret)<br> + return ret;<br> + ret = smu_send_smc_msg_with_param(smu, SMU_MSG_SetHardMinFclkByFreq, min_freq);<br> + if (ret)<br> + return ret;<br> +<o:p></o:p></p> </div> <div> <p class="MsoNormal">[kevin]:<o:p></o:p></p> </div> <div> <p class="MsoNormal">after remove this blank line,<o:p></o:p></p> </div> <div> <p class="MsoNormal">Reviewed-by: Kevin Wang <<a href="mailto:kevin1.wang@amd.com">kevin1.wang@amd.com</a>><o:p></o:p></p> </div> <div> <p class="MsoNormal">+ break;<br> + default:<br> + break;<br> + }<br> +<br> + return ret;<br> +}<br> +<br> static const struct pptable_funcs renoir_ppt_funcs = {<br> .get_smu_msg_index = renoir_get_smu_msg_index,<br> .get_smu_table_index = renoir_get_smu_table_index,<br> @@ -404,6 +485,8 @@ static const struct pptable_funcs renoir_ppt_funcs = {<br> .force_dpm_limit_value = renoir_force_dpm_limit_value,<br> .unforce_dpm_levels = renoir_unforce_dpm_levels,<br> .get_workload_type = renoir_get_workload_type,<br> + .get_profiling_clk_mask = renoir_get_profiling_clk_mask,<br> + .force_clk_levels = renoir_force_clk_levels,<br> };<br> <br> void renoir_set_ppt_funcs(struct smu_context *smu)<br> -- <br> 2.7.4<br> <br> _______________________________________________<br> amd-gfx mailing list<br> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><o:p></o:p></p> </div> </div> </div> </div> </body> </html>