<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Stop, wait a second guys!<br>
<br>
This will disable the workaround for Navi10 and that is certainly
not correct:<br>
<blockquote type="cite"><font size="2"><span
style="font-size:11pt">
!(adev->asic_type >= CHIP_NAVI10 &&
adev->asic_type <= CHIP_NAVI12)</span></font></blockquote>
<br>
Christian.<br>
<br>
<br>
Am 26.09.19 um 14:26 schrieb Deucher, Alexander:<br>
</div>
<blockquote type="cite"
cite="mid:BN6PR12MB1809591CB4102B70BEC82E93F7860@BN6PR12MB1809.namprd12.prod.outlook.com">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif;
font-size: 12pt; color: rgb(0, 0, 0);">
Please add a patch description. With that fixed:<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif;
font-size: 12pt; color: rgb(0, 0, 0);">
Reviewed-by: Alex Deucher <a class="moz-txt-link-rfc2396E" href="mailto:alexander.deucher@amd.com"><alexander.deucher@amd.com></a><br>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt"
face="Calibri, sans-serif" color="#000000"><b>From:</b>
amd-gfx <a class="moz-txt-link-rfc2396E" href="mailto:amd-gfx-bounces@lists.freedesktop.org"><amd-gfx-bounces@lists.freedesktop.org></a> on
behalf of Yuan, Xiaojie <a class="moz-txt-link-rfc2396E" href="mailto:Xiaojie.Yuan@amd.com"><Xiaojie.Yuan@amd.com></a><br>
<b>Sent:</b> Thursday, September 26, 2019 4:09 AM<br>
<b>To:</b> <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>
<a class="moz-txt-link-rfc2396E" href="mailto:amd-gfx@lists.freedesktop.org"><amd-gfx@lists.freedesktop.org></a><br>
<b>Cc:</b> <a class="moz-txt-link-abbreviated" href="mailto:alexdeucher@gmail.com">alexdeucher@gmail.com</a> <a class="moz-txt-link-rfc2396E" href="mailto:alexdeucher@gmail.com"><alexdeucher@gmail.com></a><br>
<b>Subject:</b> Re: [PATCH] drm/amdgpu/gmc10: apply the
'invalidation from sdma' workaround for navi</font>
<div> </div>
</div>
<style type="text/css" style="display:none">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div style="font-family:Calibri,Helvetica,sans-serif;
font-size:11pt; color:rgb(0,0,0)">
Hi Alex,</div>
<div style="font-family:Calibri,Helvetica,sans-serif;
font-size:11pt; color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Helvetica,sans-serif;
font-size:11pt; color:rgb(0,0,0)">
This patch is to add the asic_type check which is missing
after drm-next branch rebase.</div>
<div style="font-family:Calibri,Helvetica,sans-serif;
font-size:11pt; color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Helvetica,sans-serif;
font-size:11pt; color:rgb(0,0,0)">
BR,</div>
<div style="font-family:Calibri,Helvetica,sans-serif;
font-size:11pt; color:rgb(0,0,0)">
Xiaojie<br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font style="font-size:11pt"
face="Calibri, sans-serif" color="#000000"><b>From:</b>
Yuan, Xiaojie <a class="moz-txt-link-rfc2396E" href="mailto:Xiaojie.Yuan@amd.com"><Xiaojie.Yuan@amd.com></a><br>
<b>Sent:</b> Thursday, September 26, 2019 4:08 PM<br>
<b>To:</b> <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>
<a class="moz-txt-link-rfc2396E" href="mailto:amd-gfx@lists.freedesktop.org"><amd-gfx@lists.freedesktop.org></a><br>
<b>Cc:</b> <a class="moz-txt-link-abbreviated" href="mailto:alexdeucher@gmail.com">alexdeucher@gmail.com</a>
<a class="moz-txt-link-rfc2396E" href="mailto:alexdeucher@gmail.com"><alexdeucher@gmail.com></a>; Yuan, Xiaojie
<a class="moz-txt-link-rfc2396E" href="mailto:Xiaojie.Yuan@amd.com"><Xiaojie.Yuan@amd.com></a><br>
<b>Subject:</b> [PATCH] drm/amdgpu/gmc10: apply the
'invalidation from sdma' workaround for navi</font>
<div> </div>
</div>
<div class="x_BodyFragment"><font size="2"><span
style="font-size:11pt">
<div class="x_PlainText">Fixes: 767acabdac81
("drm/amd/powerplay: add baco smu reset function for
smu11")<br>
Signed-off-by: Xiaojie Yuan <a class="moz-txt-link-rfc2396E" href="mailto:xiaojie.yuan@amd.com"><xiaojie.yuan@amd.com></a><br>
---<br>
drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c | 1 +<br>
1 file changed, 1 insertion(+)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c<br>
index cb3f61873baa..dc2e68e019eb 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c<br>
@@ -292,6 +292,7 @@ static void
gmc_v10_0_flush_gpu_tlb(struct amdgpu_device *adev,
uint32_t vmid,<br>
<br>
if (!adev->mman.buffer_funcs_enabled ||<br>
!adev->ib_pool_ready ||<br>
+ !(adev->asic_type >= CHIP_NAVI10
&& adev->asic_type <= CHIP_NAVI12) ||<br>
adev->in_gpu_reset) {<br>
gmc_v10_0_flush_vm_hub(adev, vmid,
AMDGPU_GFXHUB_0, 0);<br>
mutex_unlock(&adev->mman.gtt_window_lock);<br>
-- <br>
2.20.1<br>
<br>
</div>
</span></font></div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
amd-gfx mailing list
<a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></pre>
</blockquote>
<br>
</body>
</html>