<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
this member should be initialize in smu driver.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<span style="color: rgb(0, 0, 0); font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt;">by default should be set "false".</span></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Best Regards,<br>
Kevin</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Liang, Prike <Prike.Liang@amd.com><br>
<b>Sent:</b> Friday, September 27, 2019 4:37 PM<br>
<b>To:</b> Wang, Kevin(Yang) <Kevin1.Wang@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Cc:</b> Huang, Ray <Ray.Huang@amd.com>; Feng, Kenneth <Kenneth.Feng@amd.com><br>
<b>Subject:</b> RE: [PATCH] drm/amd/powerplay: initlialize smu->is_apu is false by default</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Does use the default value (false) for the Boolean variable of is_apu not enough for identifying DGPU?
<br>
Anyway, initialize the is_apu during smu early initialize also fine and the patch is
<br>
<br>
Reviewed-by: Prike Liang <Prike.Liang@amd.com><br>
<br>
Thanks,<br>
Prike<br>
> -----Original Message-----<br>
> From: Wang, Kevin(Yang) <Kevin1.Wang@amd.com><br>
> Sent: Friday, September 27, 2019 2:58 PM<br>
> To: amd-gfx@lists.freedesktop.org<br>
> Cc: Huang, Ray <Ray.Huang@amd.com>; Feng, Kenneth<br>
> <Kenneth.Feng@amd.com>; Liang, Prike <Prike.Liang@amd.com>; Wang,<br>
> Kevin(Yang) <Kevin1.Wang@amd.com><br>
> Subject: [PATCH] drm/amd/powerplay: initlialize smu->is_apu is false by<br>
> default<br>
> <br>
> the member of is_apu in smu_context need to initlialize by default.<br>
> <br>
> set default value is false (dGPU)<br>
> <br>
> for patch:<br>
> drm/amd/powerplay: bypass dpm_context null pointer check guard<br>
> for some smu series<br>
> <br>
> Signed-off-by: Kevin Wang <kevin1.wang@amd.com><br>
> ---<br>
> drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 1 +<br>
> 1 file changed, 1 insertion(+)<br>
> <br>
> diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c<br>
> b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c<br>
> index 7b995b0834eb..6a64f765fcd4 100644<br>
> --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c<br>
> +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c<br>
> @@ -712,6 +712,7 @@ static int smu_early_init(void *handle)<br>
> <br>
> smu->adev = adev;<br>
> smu->pm_enabled = !!amdgpu_dpm;<br>
> + smu->is_apu = false;<br>
> mutex_init(&smu->mutex);<br>
> <br>
> return smu_set_funcs(adev);<br>
> --<br>
> 2.17.1<br>
<br>
</div>
</span></font></div>
</body>
</html>