<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Okay, I will change <span style="font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; font-size: 14.6667px; background-color: rgb(255, 255, 255); display: inline !important">dev_err
back to dev_dbg. The hex printing is still very useful.</span></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<span style="font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; font-size: 14.6667px; background-color: rgb(255, 255, 255); display: inline !important"><br>
</span></div>
<div style="color: rgb(0, 0, 0);"><span style="font-size: 14.6667px;">Yong</span></div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Kuehling, Felix <Felix.Kuehling@amd.com><br>
<b>Sent:</b> Monday, September 30, 2019 11:47 AM<br>
<b>To:</b> Zhao, Yong <Yong.Zhao@amd.com>; amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org><br>
<b>Subject:</b> Re: [PATCH 6/6] drm/amdkfd: Improve KFD IOCTL printing</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">On 2019-09-27 11:41 p.m., Zhao, Yong wrote:<br>
> The code use hex define, so should the printing. Also, printf a message<br>
> if there is a failure.<br>
><br>
> Change-Id: Ia7cc7690553bb043915b3d8c0157216c64421a60<br>
> Signed-off-by: Yong Zhao <Yong.Zhao@amd.com><br>
> ---<br>
> drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 5 +++--<br>
> 1 file changed, 3 insertions(+), 2 deletions(-)<br>
><br>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c<br>
> index c28ba0c1d7ac..d1ab09c0f522 100644<br>
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c<br>
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c<br>
> @@ -1840,7 +1840,7 @@ static long kfd_ioctl(struct file *filep, unsigned int cmd, unsigned long arg)<br>
> } else<br>
> goto err_i1;<br>
> <br>
> - dev_dbg(kfd_device, "ioctl cmd 0x%x (#%d), arg 0x%lx\n", cmd, nr, arg);<br>
> + dev_dbg(kfd_device, "ioctl cmd 0x%x (#0x%x), arg 0x%lx\n", cmd, nr, arg);<br>
> <br>
> process = kfd_get_process(current);<br>
> if (IS_ERR(process)) {<br>
> @@ -1895,7 +1895,8 @@ static long kfd_ioctl(struct file *filep, unsigned int cmd, unsigned long arg)<br>
> kfree(kdata);<br>
> <br>
> if (retcode)<br>
> - dev_dbg(kfd_device, "ret = %d\n", retcode);<br>
> + dev_err(kfd_device, "ioctl cmd (#0x%x), arg 0x%lx, ret = %d\n",<br>
> + nr, arg, retcode);<br>
<br>
NAK. We don't want to spam the kernel log with cryptic error messages <br>
every time ioctl functions fail. Please leave this as a dev_dbg message. <br>
Failing ioctl functions could be perfectly normal for a number of <br>
reasons (system call interrupted by signal, running out of event slots, <br>
timeouts on event waiting, etc). But every bug report will incorrectly <br>
blame any unrelated problem on those messages if they happen to appear <br>
in the kernel log.<br>
<br>
Regards,<br>
Felix<br>
<br>
<br>
> <br>
> return retcode;<br>
> }<br>
</div>
</span></font></div>
</body>
</html>